From: Paul Mundt <lethal@linux-sh.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Will Deacon <will.deacon@arm.com>,
Prasad <prasad@linux.vnet.ibm.com>
Subject: Re: [PATCH 5/5] sh, hw_breakpoints: Fix racy access to ptrace breakpoints
Date: Tue, 12 Apr 2011 01:28:19 +0900 [thread overview]
Message-ID: <20110411162818.GB13545@linux-sh.org> (raw)
In-Reply-To: <1302284067-7860-6-git-send-email-fweisbec@gmail.com>
On Fri, Apr 08, 2011 at 07:34:27PM +0200, Frederic Weisbecker wrote:
> While the tracer accesses ptrace breakpoints, the child task may
> concurrently exit due to a SIGKILL and thus release its breakpoints
> at the same time. We can then dereference some freed pointers.
>
> To fix this, hold a reference on the child breakpoints before
> manipulating them.
>
> Reported-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Prasad <prasad@linux.vnet.ibm.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2011-04-11 16:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 17:34 [PATCH 0/5] hw_breakpoints: Fix racy ptrace breakpoint acccesses Frederic Weisbecker
2011-04-08 17:34 ` [PATCH 1/5] ptrace: Prepare to fix racy accesses on task breakpoints Frederic Weisbecker
2011-04-11 10:47 ` Will Deacon
2011-04-12 17:54 ` Frederic Weisbecker
2011-04-13 14:34 ` Will Deacon
2011-04-13 15:10 ` Frederic Weisbecker
2011-04-25 17:37 ` Frederic Weisbecker
2011-05-04 20:28 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
2011-04-08 17:34 ` [PATCH 2/5] x86, hw_breakpoints: Fix racy access to ptrace breakpoints Frederic Weisbecker
2011-05-04 20:28 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
2011-04-08 17:34 ` [PATCH 3/5] powerpc, " Frederic Weisbecker
2011-04-22 13:16 ` Frederic Weisbecker
2011-04-24 8:04 ` K.Prasad
2011-05-04 20:29 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
2011-04-08 17:34 ` [PATCH 4/5] arm, " Frederic Weisbecker
2011-05-04 20:29 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
2011-04-08 17:34 ` [PATCH 5/5] sh, " Frederic Weisbecker
2011-04-11 16:28 ` Paul Mundt [this message]
2011-05-04 20:30 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
2011-04-25 16:17 ` [PATCH 0/5] hw_breakpoints: Fix racy ptrace breakpoint acccesses Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2011-05-03 13:25 [GIT PULL] hw_breakpoint fixes Frederic Weisbecker
2011-05-03 13:25 ` [PATCH 5/5] sh, hw_breakpoints: Fix racy access to ptrace breakpoints Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411162818.GB13545@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox