From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Keshava Munegowda <keshava_mgowda@ti.com>
Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
Date: Mon, 11 Apr 2011 21:27:42 +0200 [thread overview]
Message-ID: <20110411192741.GA2618@sortiz-mobl> (raw)
In-Reply-To: <1301393275.2253.7.camel@phoenix>
Hi Axel,
On Tue, Mar 29, 2011 at 06:07:55PM +0800, Axel Lin wrote:
> In the case of missing platform_data we do not hold a spin_lock,
> thus we should not call spin_unlock_irqrestore in the error path.
>
> Also simplify the error handling by separating the successful path
> from error path. I think this change improves readability.
Patch applied to my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-04-11 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 10:07 [PATCH] mfd: Fix usbhs_enable error handling Axel Lin
2011-03-29 10:32 ` Keshava Munegowda
2011-03-29 10:35 ` Keshava Munegowda
2011-03-29 11:06 ` Felipe Balbi
2011-04-11 19:27 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411192741.GA2618@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox