public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: adding trace-cmd's plugins to perf
Date: Tue, 12 Apr 2011 15:35:36 -0300	[thread overview]
Message-ID: <20110412183536.GA20452@ghostprotocols.net> (raw)
In-Reply-To: <20110412162245.GB2240@nowhere>

Em Tue, Apr 12, 2011 at 06:22:47PM +0200, Frederic Weisbecker escreveu:
> On Sat, Apr 09, 2011 at 09:50:29PM -0600, David Ahern wrote:
> > Right now perf script cannot process kvm tracepoints:
> > 
> > perf record -e kvm:* -p 6446 -- sleep 5
> > 
> > perf script
> >   Warning: Error: expected type 4 but read 7

> > are about merging common code between the two commands. Also, trace-cmd and perf
> > are in separate repositories so a shared lib is going to inconvenience
> > one of the two.
> 
> So, we copied the tools/perf/util/trace-event-* files from trace-cmd to perf
> a while go. Then both files took their own path, both pulling fixes/enhancement
> from each others (probably more in the trace-cmd -> perf direction).
> 
> And perf is indeed a bit backward wrt parsing, because it lacks those plugins
> for example. So now it would be nice to unify that in a common lib so that it
> works well in both.
> 
> Steve proposed a shared tools/trace.so, that perf and trace-cmd could plug
> into, I really would like to see that happening too.
> 
> I think Ingo had some reserves about this, due to potential versioning
> and compatibility that such a dynamic lib would involve.

So we don't commit to an ABI for a while, just linking with it, changing
users when changing the ABI.

I encourage David to go and add the bits of trace-cmd he needs for
support the plugins he wants used in perf on tools/lib/ and make perf
use it.

That way we again reduce the differences between the codebases, or at least
reduce the feature gap.

- Arnaldo

  reply	other threads:[~2011-04-12 18:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-10  3:50 adding trace-cmd's plugins to perf David Ahern
2011-04-12 16:22 ` Frederic Weisbecker
2011-04-12 18:35   ` Arnaldo Carvalho de Melo [this message]
2011-04-12 18:51     ` Borislav Petkov
2011-04-12 18:56       ` Arnaldo Carvalho de Melo
2011-04-12 19:01         ` Borislav Petkov
2011-04-12 19:39           ` David Ahern
2011-04-12 20:01             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110412183536.GA20452@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox