From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
cl@linux.com
Subject: Re: [PATCH 4/4]percpu_counter: use atomic64 for counter
Date: Wed, 13 Apr 2011 04:15:34 +0900 [thread overview]
Message-ID: <20110412191534.GE16342@mtj.dyndns.org> (raw)
In-Reply-To: <1302595446.3981.130.camel@sli10-conroe>
Hello,
On Tue, Apr 12, 2011 at 04:04:06PM +0800, Shaohua Li wrote:
> should tunning the batch count, but if we can make percpu_counter better, why
> not?
First of all, the lock being only in slow paths, it's quite unlikely
to get ever contended. Also, because the lock duration is always
extremely short, conversion to atomic_t isn't too likely to gain
anything significant, especially in cold paths.
That said, if it's all gains, why not? I don't know. Maybe. Given
problems in the previous patches, I don't feel too enthusiastic for
this series at this point but I'm quite sleep deprived now so it might
just be me not the patch itself.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-04-12 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 8:04 [PATCH 4/4]percpu_counter: use atomic64 for counter Shaohua Li
2011-04-12 19:15 ` Tejun Heo [this message]
2011-04-13 1:17 ` Shaohua Li
2011-04-13 3:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412191534.GE16342@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).