linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: shaohua.li@intel.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	cl@linux.com, eric.dumazet@gmail.com
Subject: Re: [patch v2 4/4] percpu_counter: use atomic64 for counter
Date: Thu, 14 Apr 2011 04:07:47 +0900	[thread overview]
Message-ID: <20110413190747.GE3987@mtj.dyndns.org> (raw)
In-Reply-To: <20110413080517.901701497@sli10-conroe.sh.intel.com>

On Wed, Apr 13, 2011 at 03:57:19PM +0800, shaohua.li@intel.com wrote:
> This can improve some workloads with percpu_counter->lock heavily contented.
> For example, vm_committed_as sometimes causes the contention. We should tune
> the batch count, but if we can make percpu_counter better, why not? In a 24
> CPUs system, 24 processes run stress mmap()/mmunmap(), the atomic method
> gives 50x faster.

Christoph already raised the issue but I'd also love to know a bit
more detail on the test than "50x faster".

Thanks.

-- 
tejun

  reply	other threads:[~2011-04-13 19:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13  7:57 [patch v2 0/4] percpu_counter: cleanup and fix shaohua.li
2011-04-13  7:57 ` [patch v2 1/4] percpu_counter: change return value and add comments shaohua.li
2011-04-13 19:05   ` Tejun Heo
2011-04-13  7:57 ` [patch v2 2/4] percpu_counter: delete dead code shaohua.li
2011-04-13 18:59   ` Tejun Heo
2011-04-18  0:12   ` Ted Ts'o
2011-04-13  7:57 ` [patch v2 3/4] percpu_counter: fix code for 32bit systems shaohua.li
2011-04-13 19:04   ` Tejun Heo
2011-04-13  7:57 ` [patch v2 4/4] percpu_counter: use atomic64 for counter shaohua.li
2011-04-13 19:07   ` Tejun Heo [this message]
2011-04-13 14:08 ` [patch v2 0/4] percpu_counter: cleanup and fix Christoph Lameter
2011-04-14  1:04   ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413190747.GE3987@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).