From: Don Zickus <dzickus@redhat.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Ingo Molnar <mingo@elte.hu>, Lin Ming <ming.m.lin@intel.com>,
Shaun Ruffell <sruffell@digium.com>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Robert Richter <robert.richter@amd.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf, x86: fix unknown NMIs on a Pentium4 box
Date: Thu, 14 Apr 2011 15:57:48 -0400 [thread overview]
Message-ID: <20110414195748.GO16939@redhat.com> (raw)
In-Reply-To: <4DA74E5D.4060002@openvz.org>
On Thu, Apr 14, 2011 at 11:43:25PM +0400, Cyrill Gorcunov wrote:
> On 04/14/2011 10:46 PM, Ingo Molnar wrote:
> >
> > btw., the bug went away once i removed your patch so it's 100% sure caused by
> > this change.
> >
> > Thanks,
> >
> > Ingo
>
> Ingo if you have a chance mind to give this patch a shot please? Seems we might miss unmasking
> for inflight nmis.
I don't think this patch will work. It would make sense if the unmasking
happened _after_ the "if (!handled)" path, but that is not the path Ingo
wanted for v1.
Cheers,
Don
> - apic_write(APIC_LVTPC, APIC_DM_NMI);
>
> handled = x86_pmu.handle_irq(args->regs);
> + apic_write(APIC_LVTPC, APIC_DM_NMI);
^^^^ all handled/unhandled NMIs hit that apic_write
> if (!handled)
> return NOTIFY_DONE;
>
next prev parent reply other threads:[~2011-04-14 19:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 14:48 [PATCH -tip] perf, x86: fix unknown NMIs on a Pentium4 box Cyrill Gorcunov
2011-04-14 15:03 ` Ingo Molnar
2011-04-14 15:06 ` Cyrill Gorcunov
2011-04-14 17:43 ` Ingo Molnar
2011-04-14 17:44 ` Ingo Molnar
2011-04-14 17:49 ` Cyrill Gorcunov
2011-04-14 18:12 ` Shaun Ruffell
2011-04-14 18:14 ` Cyrill Gorcunov
2011-04-14 18:19 ` Cyrill Gorcunov
2011-04-14 19:35 ` David Ahern
2011-04-14 17:46 ` Cyrill Gorcunov
2011-04-14 18:32 ` Don Zickus
2011-04-14 18:45 ` Ingo Molnar
2011-04-14 18:46 ` Ingo Molnar
2011-04-14 19:43 ` Cyrill Gorcunov
2011-04-14 19:57 ` Don Zickus [this message]
2011-04-14 20:05 ` Cyrill Gorcunov
2011-04-14 20:18 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414195748.GO16939@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=sruffell@digium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox