From: Greg KH <gregkh@suse.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Bill Gatliff <bgat@billgatliff.com>,
linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PWM v9 1/3] PWM: Implement a generic PWM framework
Date: Thu, 14 Apr 2011 12:58:42 -0700 [thread overview]
Message-ID: <20110414195842.GA18872@suse.de> (raw)
In-Reply-To: <BANLkTi=1Nh+EcZw_U6U8ZS2yVyqmCtuAcQ@mail.gmail.com>
On Thu, Apr 14, 2011 at 01:49:27PM -0600, Grant Likely wrote:
> > +static struct class pwm_class = {
> > + .name = "pwm",
> > + .owner = THIS_MODULE,
> > + .dev_attrs = pwm_dev_attrs,
> > +};
>
> >From my understanding, class is deprecated. I believe you should be
> using bus_type directly now. Check with Greg and Kay.
Yes, that is correct, please don't create new classes if at all
possible. And this code looks like it is fine to use a bus_type.
thanks,
greg k-h
next prev parent reply other threads:[~2011-04-14 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 3:59 [PWM v9 0/3] Implement a generic PWM framework Bill Gatliff
2011-04-01 3:59 ` [PWM v9 1/3] PWM: " Bill Gatliff
2011-04-14 19:49 ` Grant Likely
2011-04-14 19:58 ` Greg KH [this message]
2011-04-01 3:59 ` [PWM v9 2/3] PWM: GPIO+hrtimer device emulation Bill Gatliff
2011-04-06 13:17 ` Ben Gardiner
2011-04-01 3:59 ` [PWM v9 3/3] PWM: Atmel PWMC driver Bill Gatliff
2011-04-14 15:12 ` [PWM v9 0/3] Implement a generic PWM framework Bill Gatliff
2011-04-14 18:26 ` H Hartley Sweeten
2011-06-15 15:33 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414195842.GA18872@suse.de \
--to=gregkh@suse.de \
--cc=bgat@billgatliff.com \
--cc=grant.likely@secretlab.ca \
--cc=kay.sievers@vrfy.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).