From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>, Jens Axboe <jaxboe@fusionio.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.39-rc3
Date: Fri, 15 Apr 2011 00:14:55 -0400 [thread overview]
Message-ID: <20110415041455.GA27928@infradead.org> (raw)
In-Reply-To: <BANLkTi=h+NL+qqMDBNvOUmVDonORf4Qx2A@mail.gmail.com>
On Thu, Apr 14, 2011 at 01:55:02PM -0700, Linus Torvalds wrote:
> On Thu, Apr 14, 2011 at 1:24 PM, Borislav Petkov <bp@alien8.de> wrote:
> >
> > Yep, I had to hit a buglet too. Looks like block layer, ->request_fn
> > (do_ide_request) called in IRQ disabled region. Process is blkid, i.e.
> > some udev helper. Kernel is -rc3 + Joerg's USB quirk fix which should be
> > unrelated.
>
> I think this particular backtrace should be fixed by commit
> 6631e635c65d ("block: don't flush plugged IO on forced preemtion
> scheduling"), although even without preempt scheduling, I don't think
> it's at all ok to sleep inside __blk_run_queue.
>
> Jens? Even from a _regular_ schedule, it would not be ok if we end up
> sleeping - we're caching things like the request-queue, and we have
> preempt_disable() inside the scheduler for a very good reason.
Jens already has a fix in his tree to always offload the block I/O
submission to blockd for this case.
next prev parent reply other threads:[~2011-04-15 4:15 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 0:40 Linux 2.6.39-rc3 Linus Torvalds
2011-04-12 9:02 ` Joerg Roedel
2011-04-12 14:15 ` Alex Deucher
2011-04-12 18:44 ` Joerg Roedel
2011-04-13 1:27 ` David Rientjes
2011-04-13 6:46 ` Ingo Molnar
2011-04-13 17:21 ` Joerg Roedel
2011-04-13 18:39 ` H. Peter Anvin
2011-04-13 19:26 ` Joerg Roedel
2011-04-13 18:51 ` H. Peter Anvin
2011-04-13 19:24 ` Joerg Roedel
2011-04-13 19:14 ` Yinghai Lu
2011-04-13 19:34 ` Joerg Roedel
2011-04-13 20:48 ` Yinghai Lu
2011-04-13 20:54 ` Linus Torvalds
2011-04-13 21:23 ` Yinghai Lu
2011-04-13 23:39 ` Linus Torvalds
2011-04-14 0:10 ` Yinghai Lu
2011-04-14 2:03 ` H. Peter Anvin
2011-04-14 2:27 ` Linus Torvalds
2011-04-14 2:33 ` Linus Torvalds
2011-04-14 4:03 ` Tejun Heo
2011-04-14 9:36 ` Joerg Roedel
2011-04-14 8:09 ` Alan Cox
2011-04-15 13:11 ` Joerg Roedel
2011-04-15 13:16 ` Ingo Molnar
2011-04-15 14:33 ` Joerg Roedel
2011-04-15 16:11 ` Alex Deucher
2011-04-15 15:46 ` Joerg Roedel
2011-04-15 16:11 ` Jerome Glisse
2011-04-16 16:35 ` Joerg Roedel
2011-04-16 18:54 ` Jerome Glisse
2011-04-17 14:09 ` Joerg Roedel
2011-04-18 1:12 ` Jerome Glisse
2011-04-18 15:23 ` Alex Deucher
2011-04-18 15:29 ` Jerome Glisse
2011-04-18 15:33 ` Alex Deucher
2011-04-18 15:59 ` Jerome Glisse
2011-04-18 16:35 ` Alex Deucher
2011-04-15 14:04 ` Andreas Herrmann
2011-04-15 14:28 ` Joerg Roedel
2011-04-15 14:16 ` Alexandre Demers
2011-04-15 14:27 ` Joerg Roedel
2011-04-15 18:59 ` Alexandre Demers
2011-04-15 19:06 ` Ingo Molnar
2011-04-15 19:18 ` Yinghai Lu
2011-04-15 20:22 ` H. Peter Anvin
2011-04-16 12:01 ` Joerg Roedel
2011-04-16 12:00 ` Joerg Roedel
2011-04-16 12:21 ` Ingo Molnar
2011-04-16 0:03 ` [tip:x86/urgent] x86, amd: Disable GartTlbWlkErr when BIOS forgets it tip-bot for Joerg Roedel
2011-05-06 21:17 ` Linux 2.6.39-rc3 Linus Torvalds
2011-04-13 21:50 ` Joerg Roedel
2011-04-13 21:59 ` Yinghai Lu
2011-04-13 22:11 ` H. Peter Anvin
2011-04-13 22:01 ` H. Peter Anvin
2011-04-13 22:22 ` Joerg Roedel
2011-04-13 22:31 ` H. Peter Anvin
2011-04-14 8:59 ` Joerg Roedel
2011-04-13 19:48 ` Alex Deucher
2011-04-14 1:58 ` H. Peter Anvin
2011-04-14 2:07 ` Dave Airlie
2011-04-14 6:10 ` H. Peter Anvin
2011-04-14 8:56 ` Joerg Roedel
2011-04-14 9:07 ` Dave Airlie
2011-04-14 9:11 ` Ingo Molnar
2011-04-14 14:31 ` H. Peter Anvin
2011-04-14 14:28 ` Alex Deucher
2011-04-14 21:09 ` Joerg Roedel
2011-04-14 21:34 ` Alex Deucher
2011-04-15 6:50 ` Joerg Roedel
2011-04-15 14:49 ` Andreas Herrmann
2011-04-15 8:26 ` Michel Dänzer
2011-04-15 8:55 ` Joerg Roedel
2011-04-12 19:09 ` Dave Jones
2011-04-12 19:21 ` Dave Jones
2011-04-12 19:55 ` Linus Torvalds
2011-04-12 20:13 ` Dave Jones
2011-04-14 8:20 ` Aneesh Kumar K.V
2011-04-18 22:57 ` Kay Sievers
2011-04-18 23:02 ` Dave Jones
2011-04-18 23:14 ` Kay Sievers
2011-04-19 11:42 ` Ted Ts'o
2011-04-19 8:23 ` Aneesh Kumar K.V
2011-04-19 8:37 ` Steven Whitehouse
2011-04-19 9:55 ` Kay Sievers
2011-04-12 20:20 ` Eric Sandeen
2011-04-12 20:27 ` Karel Zak
2011-04-12 20:33 ` Linus Torvalds
2011-04-14 20:24 ` Borislav Petkov
2011-04-14 20:55 ` Linus Torvalds
2011-04-15 4:14 ` Christoph Hellwig [this message]
2011-04-20 20:12 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 4:32 George Spelvin
2011-04-13 14:54 ` Linus Torvalds
2011-04-14 18:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415041455.GA27928@infradead.org \
--to=hch@infradead.org \
--cc=bp@alien8.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).