From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
William Irwin <wli@holomorphy.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: hugetlb locking bug.
Date: Fri, 15 Apr 2011 16:57:12 -0400 [thread overview]
Message-ID: <20110415205712.GA13049@infradead.org> (raw)
In-Reply-To: <BANLkTi=ctr7tQLArfbdHRU3uUvEPh6KbwQ@mail.gmail.com>
On Fri, Apr 15, 2011 at 01:49:04PM -0700, Linus Torvalds wrote:
> And I really thought we annotated it as such with different
> "lockdep_set_class()" cases (ie the whole
>
> lockdep_set_class(&inode->i_mutex,&type->i_mutex_dir_key);
>
> for the S_ISDIR case in unlock_new_inode().
>
> Can somebody more alert than me see why this lockdep issue still
> triggers with hugetlbfs?
Because it doesn't use iget or unlock_new_inode, but rather calls
directly into new_inode(). It and other filesystems not using
unlock_new_inode will need a local copy of that logic.
next prev parent reply other threads:[~2011-04-15 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 20:16 hugetlb locking bug Dave Jones
2011-04-15 20:49 ` Linus Torvalds
2011-04-15 20:57 ` Christoph Hellwig [this message]
2011-04-15 21:09 ` Peter Zijlstra
2011-04-15 21:13 ` Christoph Hellwig
2011-04-15 21:23 ` Peter Zijlstra
2011-04-15 21:19 ` Linus Torvalds
2011-04-15 21:26 ` Christoph Hellwig
2011-04-15 21:27 ` Linus Torvalds
2011-12-14 11:59 ` Mimi Zohar
2011-04-15 21:07 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2011-08-22 15:34 Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415205712.GA13049@infradead.org \
--to=hch@infradead.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox