From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: wanlong.gao@gmail.com
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH]drivers:regulator:change the dev_dbg in the probe function
Date: Sat, 16 Apr 2011 18:54:40 +0100 [thread overview]
Message-ID: <20110416175440.GD25811@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1302968543-3150-1-git-send-email-wanlong.gao@gmail.com>
On Sat, Apr 16, 2011 at 11:42:23PM +0800, wanlong.gao@gmail.com wrote:
Please ensure that you use subject lines for your patch which fit in
with the style of other changes to the subsystem.
> change the function name string to "%s".
You should also explain why a change is being made, not what the change
is (we can see that from the patch). In this case what you're doing is
making this debug statement be consistent with the style of the rest of
the file.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com
next prev parent reply other threads:[~2011-04-16 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 15:42 [PATCH]drivers:regulator:change the dev_dbg in the probe function wanlong.gao
2011-04-16 17:54 ` Mark Brown [this message]
2011-04-17 0:53 ` [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest Wanlong Gao
2011-04-17 9:19 ` Harry Wei
2011-04-17 10:11 ` Wanlong Gao
[not found] ` <BANLkTi=vqFs11=VBk=2jxH+mDY3xBxwj7g@mail.gmail.com>
2011-04-17 10:22 ` Harry Wei
2011-05-10 8:12 ` Jiri Kosina
2011-05-10 12:36 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110416175440.GD25811@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=trivial@kernel.org \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox