public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, wanlong.gao@gmail.com
Subject: Re: [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum".
Date: Mon, 18 Apr 2011 12:28:30 +0800	[thread overview]
Message-ID: <20110418042828.GA1904@gmail.com> (raw)
In-Reply-To: <014287655bd0c4327bbd946b9c823a0e4ec35f8e.1303079016.git.tfransosi@gmail.com>

On Sun, Apr 17, 2011 at 07:34:14PM -0300, Thiago Farina wrote:
> Instead use the keyword "enum" where we use it.
> 
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
>  drivers/usb/image/mdc800.c |  111 +++++++++++++++++++++----------------------
This is well for me.
>  	NOT_CONNECTED, READY, WORKING, DOWNLOAD
> -} mdc800_state;
> +};
>  
>  
> -/* Data for the driver */
> +/* Data for the driver. */
>  struct mdc800_data
>  {
> -	struct usb_device *	dev;			// Device Data
> -	mdc800_state 		state;
> +	struct usb_device*      dev;                  /* Device Data. */
This should be 'struct usb_device	*dev'. The same as
following. See Documentation/CodingStyle for details.
> +	enum mdc800_state	state;
>  
> -	unsigned int		endpoint [4];
> +	unsigned int		endpoint[4];
>  
> -	struct urb *		irq_urb;
> +	struct urb*             irq_urb;
>  	wait_queue_head_t	irq_wait;

      parent reply	other threads:[~2011-04-18  4:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17 22:34 [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum" Thiago Farina
2011-04-18  0:54 ` Wanlong Gao
2011-04-18  4:09   ` Thiago Farina
2011-04-18  4:22     ` Arnd Bergmann
2011-04-18  7:26   ` Oliver Neukum
2011-04-18 17:27     ` Wanlong Gao
2011-04-19  7:09       ` Oliver Neukum
2011-04-18  4:28 ` Harry Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110418042828.GA1904@gmail.com \
    --to=jiaweiwei.xiyou@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tfransosi@gmail.com \
    --cc=wanlong.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox