From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: jaxboe@fusionio.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: block: add blk_run_queue_async
Date: Mon, 18 Apr 2011 16:20:53 -0400 [thread overview]
Message-ID: <20110418202053.GA29394@redhat.com> (raw)
In-Reply-To: <20110418195929.GA9650@infradead.org>
On Mon, Apr 18 2011 at 3:59pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Apr 18, 2011 at 03:55:04PM -0400, Mike Snitzer wrote:
> > > +{
> > > + ? ? ? if (likely(!blk_queue_stopped(q)))
> > > + ? ? ? ? ? ? ? queue_delayed_work(kblockd_workqueue, &q->delay_work, 0);
> >
> > I know Jens already queued this up 'for-linus' but why not use
> > kblockd_schedule_work(q, &q->delay_work)?
>
> I don't see what that would buy us. If we'd absolutely want a wrapper
> a blk_delay_queue(q, 0) in Jens' current tree would do it now that is
> has been fixed up to use the kblockd workqueue.
Right, I missed 4521cc4 block: blk_delay_queue() should use kblockd
workqueue. So why not use blk_delay_queue()?
I agree with Jens that it doesn't much matter but I also cannot see it
being a bad thing.. I'd prefer it ;)
*shrug*
next prev parent reply other threads:[~2011-04-18 20:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 9:26 [PATCH] block: add blk_run_queue_async Christoph Hellwig
2011-04-18 9:38 ` Jens Axboe
2011-04-18 15:33 ` Tao Ma
2011-04-18 16:33 ` Christoph Hellwig
2011-04-18 19:55 ` Mike Snitzer
2011-04-18 19:59 ` Christoph Hellwig
2011-04-18 20:01 ` Jens Axboe
2011-04-18 20:20 ` Mike Snitzer [this message]
2011-04-18 21:48 ` Mike Snitzer
2011-04-19 14:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418202053.GA29394@redhat.com \
--to=snitzer@redhat.com \
--cc=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox