From: Oliver Neukum <oneukum@suse.de>
To: Wanlong Gao <wanlong.gao@gmail.com>
Cc: Thiago Farina <tfransosi@gmail.com>,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@suse.de>,
Arnd Bergmann <arnd@arndb.de>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum".
Date: Tue, 19 Apr 2011 09:09:04 +0200 [thread overview]
Message-ID: <201104190909.04206.oneukum@suse.de> (raw)
In-Reply-To: <4DAC7487.6050204@gmail.com>
Am Montag, 18. April 2011, 19:27:35 schrieb Wanlong Gao:
> 2011-4-18 15:26, Oliver Neukum wroted:
> > Am Montag, 18. April 2011, 02:54:16 schrieb Wanlong Gao:
> >>> -
> >>> /***************************************************************************
> >>> The USB Part of the driver
> >>> ****************************************************************************/
> >>> --
> >>> 1.7.3.2.343.g7d43d
> >>>
> >> Why did you change it ? and why change so many lines ?
> >> It had some thing wrong ?
> >
> > Exactly. This is a driver for legacy hardware. Could you leave it alone
> > unless you fix a real, as in makes a difference to code generation, bug?
> >
> > Regards
> > Oliver
> Hmm..Maybe he just want to make to code nice . and didn't think as more
> about this as you .
Yes, I appreciate that, but the number of testers for these devices is low,
but there are still users.
Regards
Oliver
next prev parent reply other threads:[~2011-04-19 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 22:34 [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum" Thiago Farina
2011-04-18 0:54 ` Wanlong Gao
2011-04-18 4:09 ` Thiago Farina
2011-04-18 4:22 ` Arnd Bergmann
2011-04-18 7:26 ` Oliver Neukum
2011-04-18 17:27 ` Wanlong Gao
2011-04-19 7:09 ` Oliver Neukum [this message]
2011-04-18 4:28 ` Harry Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104190909.04206.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tfransosi@gmail.com \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox