From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Florian Mickler <florian@mickler.org>, Neil Brown <neilb@suse.de>
Subject: Re: [Bug #32982] Kernel locks up a few minutes after boot
Date: Tue, 19 Apr 2011 12:48:15 -0400 [thread overview]
Message-ID: <20110419164815.GA30616@infradead.org> (raw)
In-Reply-To: <4DAD6EF2.5070405@fusionio.com>
> + blk_run_queue_async(sdev->request_queue);
This doesn't even have to be async except when scsi drivers call
cmd->scsi_done directly. It seems like if this always went through the
softirq (or kblockd) we could still run it in context for the others.
> + /*
> + * This get/put dance makes no sense
> + */
> get_device(&rport->dev);
> -
> - spin_lock_irqsave(rport->rqst_q->queue_lock, flags);
> - flagset = test_bit(QUEUE_FLAG_REENTER, &rport->rqst_q->queue_flags) &&
> - !test_bit(QUEUE_FLAG_REENTER, &rport->rqst_q->queue_flags);
> - if (flagset)
> - queue_flag_set(QUEUE_FLAG_REENTER, rport->rqst_q);
> - __blk_run_queue(rport->rqst_q);
> - if (flagset)
> - queue_flag_clear(QUEUE_FLAG_REENTER, rport->rqst_q);
> - spin_unlock_irqrestore(rport->rqst_q->queue_lock, flags);
> -
> + blk_run_queue_async(rport->rqst_q);
And the QUEUE_FLAG_REENTER mess here never made sense either as it
tested for a bit beeing set and not set at the same time. So this one
actually should be able to be replaced by a plain blk_run_queue.
next prev parent reply other threads:[~2011-04-19 16:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 12:52 2.6.39-rc3-git7: Reported regressions from 2.6.38 Rafael J. Wysocki
2011-04-17 12:52 ` [Bug #32262] 2.6.38-git15+ IDE hangs boot Rafael J. Wysocki
2011-04-17 13:16 ` Pete Clements
2011-04-17 13:28 ` Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33092] [regression] 2.6.39-rc1 - Beagleboard usbnet broken Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #32902] 2.6.39-rc1 doesn't boot on thinkpad t61p x86_64 Rafael J. Wysocki
2011-04-18 15:34 ` Alex Romosan
2011-04-18 21:22 ` Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #32982] Kernel locks up a few minutes after boot Rafael J. Wysocki
2011-04-17 17:03 ` Linus Torvalds
2011-04-17 18:37 ` Bart Van Assche
2011-04-17 21:07 ` NeilBrown
2011-04-17 22:20 ` NeilBrown
2011-04-18 11:44 ` Jens Axboe
2011-04-18 18:21 ` Bart Van Assche
2011-04-18 18:28 ` Jens Axboe
2011-04-18 18:32 ` Bart Van Assche
2011-04-18 18:38 ` Jens Axboe
2011-04-19 9:09 ` Jens Axboe
2011-04-19 11:16 ` Jens Axboe
2011-04-19 16:13 ` Bart Van Assche
2011-04-19 16:32 ` Linus Torvalds
2011-04-19 17:43 ` Jens Axboe
2011-04-19 17:43 ` Jens Axboe
2011-04-19 16:48 ` Christoph Hellwig [this message]
2011-04-19 17:06 ` Jens Axboe
2011-04-19 3:32 ` David Dillow
2011-04-19 16:39 ` Bart Van Assche
2011-04-21 0:38 ` Dave Dillow
2011-04-17 12:57 ` [Bug #32892] 2.6.39-rc1 data corruption with rtorrent Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33272] drm related hard-hang Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33102] File's copied from client->linux server only copy 1st 64K data;rest is lost Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33252] [regression 2.6.39-rc2][bisected] "perf, x86: P4 PMU - Read proper MSR register to catch" and NMIs Rafael J. Wysocki
2011-04-17 13:05 ` Cyrill Gorcunov
2011-04-17 13:31 ` Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33142] 2.6.39-rc2 regression: X201s fails to resume b77dcf8460ae57d4eb9fd3633eb4f97b8fb20716 Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33242] Lockdep splat in autofs with 2.6.39-rc2 Rafael J. Wysocki
2011-04-17 12:57 ` [Bug #33342] [2.6.39-rc2][bisected] Constant DISK_MEDIA_CHANGE_EVENTS from CDROM drive Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2011-04-30 19:42 2.6.39-rc5-git4: Reported regressions from 2.6.38 Rafael J. Wysocki
2011-04-30 19:42 ` [Bug #32982] Kernel locks up a few minutes after boot Rafael J. Wysocki
2011-04-30 19:51 ` Linus Torvalds
[not found] ` <BANLkTik_aeVn9Jf_cWnoY0fNUm+tjMnixA@mail.gmail.com>
2011-05-01 17:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419164815.GA30616@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=florian@mickler.org \
--cc=jaxboe@fusionio.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox