* [PATCH -next reresend] i2c: designware-pcidrv depends on PCI @ 2011-04-08 15:32 Randy Dunlap 2011-04-09 11:34 ` Geert Uytterhoeven 0 siblings, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2011-04-08 15:32 UTC (permalink / raw) To: Stephen Rothwell, Baruch Siach, linux-i2c Cc: linux-next, LKML, khali, ben-linux From: Randy Dunlap <randy.dunlap@oracle.com> i2c-designware-pcidrv is a PCI driver and should depend on PCI. Fixes these build errors: drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Baruch Siach <baruch@tkos.co.il> --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+) Does anybody merge i2c patches??? --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig +++ linux-next-20110316/drivers/i2c/busses/Kconfig @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM config I2C_DESIGNWARE_PCI tristate "Synopsys DesignWare PCI" + depends on PCI help If you say yes to this option, support will be included for the Synopsys DesignWare I2C adapter. Only master mode is supported. -- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI 2011-04-08 15:32 [PATCH -next reresend] i2c: designware-pcidrv depends on PCI Randy Dunlap @ 2011-04-09 11:34 ` Geert Uytterhoeven 2011-04-12 9:47 ` Jean Delvare 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2011-04-09 11:34 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Baruch Siach, linux-i2c, linux-next, LKML, khali, ben-linux On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > i2c-designware-pcidrv is a PCI driver and should depend on PCI. > Fixes these build errors: > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Baruch Siach <baruch@tkos.co.il> > --- > drivers/i2c/busses/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Does anybody merge i2c patches??? Yes please, it's been there since Mar 17, reported several times, and probably masking other build failures. > --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig > +++ linux-next-20110316/drivers/i2c/busses/Kconfig > @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM > > config I2C_DESIGNWARE_PCI > tristate "Synopsys DesignWare PCI" > + depends on PCI > help > If you say yes to this option, support will be included for the > Synopsys DesignWare I2C adapter. Only master mode is supported. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI 2011-04-09 11:34 ` Geert Uytterhoeven @ 2011-04-12 9:47 ` Jean Delvare 2011-04-12 15:48 ` Randy Dunlap 2011-04-12 22:38 ` Stephen Rothwell 0 siblings, 2 replies; 6+ messages in thread From: Jean Delvare @ 2011-04-12 9:47 UTC (permalink / raw) To: Geert Uytterhoeven, Randy Dunlap, Stephen Rothwell, Ben Dooks Cc: Baruch Siach, linux-i2c, linux-next, LKML Geert, Randy, On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote: > On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > i2c-designware-pcidrv is a PCI driver and should depend on PCI. > > Fixes these build errors: > > > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' > > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Cc: Baruch Siach <baruch@tkos.co.il> > > --- > > drivers/i2c/busses/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > Does anybody merge i2c patches??? > > Yes please, it's been there since Mar 17, reported several times, and probably > masking other build failures. This bug only exists in linux-next, as the code in question wasn't merged in Linus's tree yet. It is drawn into linux-next from Ben Dooks's next-i2c branch: http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c This is where it has to be fixed, so only Ben can do it. Ben, please? Meanwhile, it should be possible to apply a hot fix to linux-next directly, Stephen does it pretty often. Stephen, could you please apply this fix temporarily until Ben wakes up and applies it to his tree? > > --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig > > +++ linux-next-20110316/drivers/i2c/busses/Kconfig > > @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM > > > > config I2C_DESIGNWARE_PCI > > tristate "Synopsys DesignWare PCI" > > + depends on PCI > > help > > If you say yes to this option, support will be included for the > > Synopsys DesignWare I2C adapter. Only master mode is supported. -- Jean Delvare ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI 2011-04-12 9:47 ` Jean Delvare @ 2011-04-12 15:48 ` Randy Dunlap 2011-04-12 22:38 ` Stephen Rothwell 1 sibling, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2011-04-12 15:48 UTC (permalink / raw) To: Jean Delvare Cc: Geert Uytterhoeven, Stephen Rothwell, Ben Dooks, Baruch Siach, linux-i2c, linux-next, LKML On 04/12/11 02:47, Jean Delvare wrote: > Geert, Randy, > > On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote: >> On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote: >>> From: Randy Dunlap <randy.dunlap@oracle.com> >>> >>> i2c-designware-pcidrv is a PCI driver and should depend on PCI. >>> Fixes these build errors: >>> >>> drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' >>> drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >>> Cc: Baruch Siach <baruch@tkos.co.il> >>> --- >>> drivers/i2c/busses/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> Does anybody merge i2c patches??? >> >> Yes please, it's been there since Mar 17, reported several times, and probably >> masking other build failures. > > This bug only exists in linux-next, as the code in question wasn't > merged in Linus's tree yet. It is drawn into linux-next from Ben > Dooks's next-i2c branch: > http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c > > This is where it has to be fixed, so only Ben can do it. Ben, please? > > Meanwhile, it should be possible to apply a hot fix to linux-next > directly, Stephen does it pretty often. Stephen, could you please apply > this fix temporarily until Ben wakes up and applies it to his tree? Thanks, Jean. >>> --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig >>> +++ linux-next-20110316/drivers/i2c/busses/Kconfig >>> @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM >>> >>> config I2C_DESIGNWARE_PCI >>> tristate "Synopsys DesignWare PCI" >>> + depends on PCI >>> help >>> If you say yes to this option, support will be included for the >>> Synopsys DesignWare I2C adapter. Only master mode is supported. > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI 2011-04-12 9:47 ` Jean Delvare 2011-04-12 15:48 ` Randy Dunlap @ 2011-04-12 22:38 ` Stephen Rothwell 2011-04-19 21:45 ` Ben Dooks 1 sibling, 1 reply; 6+ messages in thread From: Stephen Rothwell @ 2011-04-12 22:38 UTC (permalink / raw) To: Jean Delvare, Ben Dooks Cc: Geert Uytterhoeven, Randy Dunlap, Baruch Siach, linux-i2c, linux-next, LKML [-- Attachment #1: Type: text/plain, Size: 1905 bytes --] Hi Jean, Ben, On Tue, 12 Apr 2011 11:47:22 +0200 Jean Delvare <khali@linux-fr.org> wrote: > > On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote: > > On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > > > i2c-designware-pcidrv is a PCI driver and should depend on PCI. > > > Fixes these build errors: > > > > > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' > > > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' > > > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > > Cc: Baruch Siach <baruch@tkos.co.il> > > > --- > > > drivers/i2c/busses/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > Does anybody merge i2c patches??? > > > > Yes please, it's been there since Mar 17, reported several times, and probably > > masking other build failures. > > This bug only exists in linux-next, as the code in question wasn't > merged in Linus's tree yet. It is drawn into linux-next from Ben > Dooks's next-i2c branch: > http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c > > This is where it has to be fixed, so only Ben can do it. Ben, please? > > Meanwhile, it should be possible to apply a hot fix to linux-next > directly, Stephen does it pretty often. Stephen, could you please apply > this fix temporarily until Ben wakes up and applies it to his tree? I will apply this patch as a merge fixup from today (if it is still needed). I also have a patch being applied to that tree to add an include of linux/delay.h to drivers/i2c/busses/i2c-designware-core.c . Ben? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI 2011-04-12 22:38 ` Stephen Rothwell @ 2011-04-19 21:45 ` Ben Dooks 0 siblings, 0 replies; 6+ messages in thread From: Ben Dooks @ 2011-04-19 21:45 UTC (permalink / raw) To: Stephen Rothwell Cc: Jean Delvare, Ben Dooks, Geert Uytterhoeven, Randy Dunlap, Baruch Siach, linux-i2c, linux-next, LKML On Wed, Apr 13, 2011 at 08:38:55AM +1000, Stephen Rothwell wrote: > Hi Jean, Ben, > > On Tue, 12 Apr 2011 11:47:22 +0200 Jean Delvare <khali@linux-fr.org> wrote: > > > > On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote: > > > On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > > > > > i2c-designware-pcidrv is a PCI driver and should depend on PCI. > > > > Fixes these build errors: > > > > > > > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' > > > > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' > > > > > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > > > Cc: Baruch Siach <baruch@tkos.co.il> > > > > --- > > > > drivers/i2c/busses/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > Does anybody merge i2c patches??? > > > > > > Yes please, it's been there since Mar 17, reported several times, and probably > > > masking other build failures. > > > > This bug only exists in linux-next, as the code in question wasn't > > merged in Linus's tree yet. It is drawn into linux-next from Ben > > Dooks's next-i2c branch: > > http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c > > > > This is where it has to be fixed, so only Ben can do it. Ben, please? > > > > Meanwhile, it should be possible to apply a hot fix to linux-next > > directly, Stephen does it pretty often. Stephen, could you please apply > > this fix temporarily until Ben wakes up and applies it to his tree? > > I will apply this patch as a merge fixup from today (if it is still > needed). I also have a patch being applied to that tree to add an > include of linux/delay.h to drivers/i2c/busses/i2c-designware-core.c . I've not gotten around to fixing the rebase of the driver to the latest source code, I'll try and get around to it in the next few days unless someone sends a new copy of the patch. > Ben? > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-19 21:45 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-04-08 15:32 [PATCH -next reresend] i2c: designware-pcidrv depends on PCI Randy Dunlap 2011-04-09 11:34 ` Geert Uytterhoeven 2011-04-12 9:47 ` Jean Delvare 2011-04-12 15:48 ` Randy Dunlap 2011-04-12 22:38 ` Stephen Rothwell 2011-04-19 21:45 ` Ben Dooks
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox