From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Richard Nauber <richard.nauber@googlemail.com>,
PenMount <penmount.touch@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
Stephane Chatty <chatty@lii-enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
PenMount <salt@salt.com.tw>
Subject: Re: [PATCH] HID: add support for PenMount dual-touch panel
Date: Wed, 20 Apr 2011 12:07:59 +0200 [thread overview]
Message-ID: <20110420100759.GA2436@polaris.bitmath.org> (raw)
In-Reply-To: <BANLkTin7Q3fD3vg90qCk12MGaVEvLBe0Mg@mail.gmail.com>
> > Benjamin: Since field->index == 0 is in use, it seems the driver could
> > execute event emission wrongly under some circumstances (when
> > last_field_index == 0). Is that related to the reason for the quirk in
> > this patch?
>
> In fact, I have a second patch just on top of this one. It has been
> tested by Ryan with PenMount devices.
Great, and good timing. :-)
> I was waiting for Penmount to be included first as it does not impact
> any other drivers.
I would prefer the opposite order, since it is cleaner and means one
less device to test for the major change.
>
> I inline the code here, but my gmail client will destroy tabs (so I
> attached it too)....
>
> Can you test it against 3M?
I will test it against 3M and egalax. Thanks!
Henrik
next prev parent reply other threads:[~2011-04-20 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 9:19 [PATCH] HID: add support for PenMount dual-touch panel PenMount
2011-04-20 9:47 ` Henrik Rydberg
2011-04-20 9:54 ` Benjamin Tissoires
2011-04-20 10:07 ` Henrik Rydberg [this message]
2011-04-21 9:17 ` Jiri Kosina
2011-04-21 10:53 ` Benjamin Tissoires
2011-04-21 11:58 ` Henrik Rydberg
2011-04-21 12:05 ` Benjamin Tissoires
[not found] ` <201104201054.36974.dmitry.torokhov@gmail.com>
[not found] ` <BANLkTikwjPc9w-HJLitBYG1tdix1U=4ckg@mail.gmail.com>
2011-04-21 6:58 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-04-21 7:31 John Sung
2011-04-21 12:16 [PATCH 2/2] " Benjamin Tissoires
2011-04-21 14:21 ` [PATCH] " Benjamin Tissoires
2011-04-22 9:57 ` Jiri Kosina
2011-04-22 10:12 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420100759.GA2436@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@enac.fr \
--cc=chatty@lii-enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penmount.touch@gmail.com \
--cc=richard.nauber@googlemail.com \
--cc=salt@salt.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox