* [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
@ 2011-03-26 16:16 ` Ralf Thielow
2011-03-26 18:51 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 16:16 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ralf Thielow
Includes missing KERN_ facility level to printk().
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
drivers/staging/keucr/smscsi.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index c3db085..20386ce 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
@@ -110,8 +110,8 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
*/
us->bl_num = bl_num;
- printk("bl_len = %x\n", bl_len);
- printk("bl_num = %x\n", bl_num);
+ printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
+ printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
buf[0] = (bl_num >> 24) & 0xff;
buf[1] = (bl_num >> 16) & 0xff;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
@ 2011-03-26 18:51 ` Joe Perches
2011-03-26 19:11 ` Ralf Thielow
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2011-03-26 18:51 UTC (permalink / raw)
To: Ralf Thielow; +Cc: gregkh, devel, linux-kernel
On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
> Includes missing KERN_ facility level to printk().
[]
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
[]
> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
> WORD bl_len;
> BYTE buf[8];
>
> - printk("SM_SCSI_Read_Capacity\n");
> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
There should not be a comma between KERN_<level> and format.
Compile tested?
> + printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
> + printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 18:51 ` Joe Perches
@ 2011-03-26 19:11 ` Ralf Thielow
2011-03-26 19:26 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 19:11 UTC (permalink / raw)
To: Joe Perches; +Cc: gregkh, devel, linux-kernel
Of course, the whole staging directory with "make clean
M=drivers/staging && make M=drivers/staging".
You're right. The "printk" function accept these but it's wrong.
Thanks
2011/3/26 Joe Perches <joe@perches.com>:
> On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
>> Includes missing KERN_ facility level to printk().
> []
>> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
> []
>> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
>> WORD bl_len;
>> BYTE buf[8];
>>
>> - printk("SM_SCSI_Read_Capacity\n");
>> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
>
> There should not be a comma between KERN_<level> and format.
>
> Compile tested?
>
>> + printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
>> + printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
@ 2011-03-26 19:21 Ralf Thielow
2011-04-20 20:48 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 19:21 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ralf Thielow
Includes missing KERN_ facility level to printk().
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
drivers/staging/keucr/smscsi.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index c3db085..5448812 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
@@ -110,8 +110,8 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
*/
us->bl_num = bl_num;
- printk("bl_len = %x\n", bl_len);
- printk("bl_num = %x\n", bl_num);
+ printk(KERN_DEBUG "bl_len = %x\n", bl_len);
+ printk(KERN_DEBUG "bl_num = %x\n", bl_num);
buf[0] = (bl_num >> 24) & 0xff;
buf[1] = (bl_num >> 16) & 0xff;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 19:11 ` Ralf Thielow
@ 2011-03-26 19:26 ` Joe Perches
2011-03-26 19:33 ` Ralf Thielow
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2011-03-26 19:26 UTC (permalink / raw)
To: Ralf Thielow; +Cc: devel, gregkh, linux-kernel
On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote:
> Of course, the whole staging directory with "make clean
> M=drivers/staging && make M=drivers/staging".
> You're right. The "printk" function accept these but it's wrong.
Then you didn't really compile test it.
I suggest you check your compilation commands.
For instance:
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index 6211686..dd3cf95 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
$ make drivers/staging/keucr/smscsi.o
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC drivers/staging/keucr/smscsi.o
drivers/staging/keucr/smscsi.c: In function ‘SM_SCSI_Read_Capacity’:
drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 19:26 ` Joe Perches
@ 2011-03-26 19:33 ` Ralf Thielow
0 siblings, 0 replies; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 19:33 UTC (permalink / raw)
To: Joe Perches; +Cc: devel, gregkh, linux-kernel
Ooops, i thougth i can trust "make M=***".
Thanks!
2011/3/26 Joe Perches <joe@perches.com>:
> On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote:
>> Of course, the whole staging directory with "make clean
>> M=drivers/staging && make M=drivers/staging".
>> You're right. The "printk" function accept these but it's wrong.
>
> Then you didn't really compile test it.
> I suggest you check your compilation commands.
>
> For instance:
>
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
> index 6211686..dd3cf95 100644
> --- a/drivers/staging/keucr/smscsi.c
> +++ b/drivers/staging/keucr/smscsi.c
> @@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
> WORD bl_len;
> BYTE buf[8];
>
> - printk("SM_SCSI_Read_Capacity\n");
> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
>
> bl_len = 0x200;
> bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
>
> $ make drivers/staging/keucr/smscsi.o
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CC drivers/staging/keucr/smscsi.o
> drivers/staging/keucr/smscsi.c: In function ‘SM_SCSI_Read_Capacity’:
> drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 19:21 [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
@ 2011-04-20 20:48 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2011-04-20 20:48 UTC (permalink / raw)
To: Ralf Thielow; +Cc: gregkh, devel, linux-kernel
On Sat, Mar 26, 2011 at 08:21:59PM +0100, Ralf Thielow wrote:
> Includes missing KERN_ facility level to printk().
>
> Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
> ---
> drivers/staging/keucr/smscsi.c | 6 +++---
Does not apply cleanly :(
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-04-20 20:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-26 19:21 [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-04-20 20:48 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-03-26 18:51 ` Joe Perches
2011-03-26 19:11 ` Ralf Thielow
2011-03-26 19:26 ` Joe Perches
2011-03-26 19:33 ` Ralf Thielow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox