* [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
@ 2011-03-26 19:21 Ralf Thielow
2011-04-20 20:48 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 19:21 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ralf Thielow
Includes missing KERN_ facility level to printk().
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
drivers/staging/keucr/smscsi.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index c3db085..5448812 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
@@ -110,8 +110,8 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
*/
us->bl_num = bl_num;
- printk("bl_len = %x\n", bl_len);
- printk("bl_num = %x\n", bl_num);
+ printk(KERN_DEBUG "bl_len = %x\n", bl_len);
+ printk(KERN_DEBUG "bl_num = %x\n", bl_num);
buf[0] = (bl_num >> 24) & 0xff;
buf[1] = (bl_num >> 16) & 0xff;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors.
@ 2011-03-26 16:16 Ralf Thielow
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 16:16 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ralf Thielow
This cleanup fixes most of the checkpatch warnings and errors.
Remaining warnings and errors are left untouched on purpose to
avoid making the code less readable. This cleanup also removes
some worthless comments.
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
drivers/staging/keucr/smscsi.c | 148 +++++++++++++++++++++-------------------
1 files changed, 79 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index 6211686..c3db085 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -9,26 +9,24 @@
#include "usb.h"
#include "scsiglue.h"
#include "transport.h"
-//#include "smcommon.h"
#include "smil.h"
-int SM_SCSI_Test_Unit_Ready (struct us_data *us, struct scsi_cmnd *srb);
-int SM_SCSI_Inquiry (struct us_data *us, struct scsi_cmnd *srb);
-int SM_SCSI_Mode_Sense (struct us_data *us, struct scsi_cmnd *srb);
-int SM_SCSI_Start_Stop (struct us_data *us, struct scsi_cmnd *srb);
-int SM_SCSI_Read_Capacity (struct us_data *us, struct scsi_cmnd *srb);
-int SM_SCSI_Read (struct us_data *us, struct scsi_cmnd *srb);
-int SM_SCSI_Write (struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Test_Unit_Ready(struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Inquiry(struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Mode_Sense(struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Start_Stop(struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb);
+int SM_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb);
-extern struct SSFDCTYPE Ssfdc;
-extern struct ADDRESS Media;
-extern PBYTE SMHostAddr;
-extern DWORD ErrXDCode;
+extern struct SSFDCTYPE Ssfdc;
+extern struct ADDRESS Media;
+extern PBYTE SMHostAddr;
+extern DWORD ErrXDCode;
-//----- SM_SCSIIrp() --------------------------------------------------
int SM_SCSIIrp(struct us_data *us, struct scsi_cmnd *srb)
{
- int result;
+ int result;
us->SrbStatus = SS_SUCCESS;
switch (srb->cmnd[0])
@@ -48,99 +46,108 @@ int SM_SCSIIrp(struct us_data *us, struct scsi_cmnd *srb)
return result;
}
-//----- SM_SCSI_Test_Unit_Ready() --------------------------------------------------
int SM_SCSI_Test_Unit_Ready(struct us_data *us, struct scsi_cmnd *srb)
{
- //printk("SM_SCSI_Test_Unit_Ready\n");
- if (us->SM_Status.Insert && us->SM_Status.Ready)
+ /* printk("SM_SCSI_Test_Unit_Ready\n"); */
+ if (us->SM_Status.Insert && us->SM_Status.Ready) {
return USB_STOR_TRANSPORT_GOOD;
- else
- {
+ } else {
ENE_SMInit(us);
return USB_STOR_TRANSPORT_GOOD;
}
-
+
return USB_STOR_TRANSPORT_GOOD;
}
-//----- SM_SCSI_Inquiry() --------------------------------------------------
int SM_SCSI_Inquiry(struct us_data *us, struct scsi_cmnd *srb)
{
- //printk("SM_SCSI_Inquiry\n");
- BYTE data_ptr[36] = {0x00, 0x80, 0x02, 0x00, 0x1F, 0x00, 0x00, 0x00, 0x55, 0x53, 0x42, 0x32, 0x2E, 0x30, 0x20, 0x20, 0x43, 0x61, 0x72, 0x64, 0x52, 0x65, 0x61, 0x64, 0x65, 0x72, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x30, 0x31, 0x30, 0x30};
+ /* printk("SM_SCSI_Inquiry\n"); */
+ BYTE data_ptr[36] = {0x00, 0x80, 0x02, 0x00, 0x1F, 0x00,
+ 0x00, 0x00, 0x55, 0x53, 0x42, 0x32,
+ 0x2E, 0x30, 0x20, 0x20, 0x43, 0x61,
+ 0x72, 0x64, 0x52, 0x65, 0x61, 0x64,
+ 0x65, 0x72, 0x20, 0x20, 0x20, 0x20,
+ 0x20, 0x20, 0x30, 0x31, 0x30, 0x30};
usb_stor_set_xfer_buf(us, data_ptr, 36, srb, TO_XFER_BUF);
return USB_STOR_TRANSPORT_GOOD;
}
-//----- SM_SCSI_Mode_Sense() --------------------------------------------------
int SM_SCSI_Mode_Sense(struct us_data *us, struct scsi_cmnd *srb)
{
- BYTE mediaNoWP[12] = {0x0b,0x00,0x00,0x08,0x00,0x00,0x71,0xc0,0x00,0x00,0x02,0x00};
- BYTE mediaWP[12] = {0x0b,0x00,0x80,0x08,0x00,0x00,0x71,0xc0,0x00,0x00,0x02,0x00};
+ BYTE mediaNoWP[12] = {0x0b, 0x00, 0x00, 0x08, 0x00, 0x00,
+ 0x71, 0xc0, 0x00, 0x00, 0x02, 0x00};
+ BYTE mediaWP[12] = {0x0b, 0x00, 0x80, 0x08, 0x00, 0x00,
+ 0x71, 0xc0, 0x00, 0x00, 0x02, 0x00};
if (us->SM_Status.WtP)
usb_stor_set_xfer_buf(us, mediaWP, 12, srb, TO_XFER_BUF);
else
usb_stor_set_xfer_buf(us, mediaNoWP, 12, srb, TO_XFER_BUF);
-
return USB_STOR_TRANSPORT_GOOD;
}
-//----- SM_SCSI_Read_Capacity() --------------------------------------------------
int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
{
unsigned int offset = 0;
struct scatterlist *sg = NULL;
- DWORD bl_num;
- WORD bl_len;
- BYTE buf[8];
+ DWORD bl_num;
+ WORD bl_len;
+ BYTE buf[8];
printk("SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
- //printk("MaxLogBlocks = %x\n", Ssfdc.MaxLogBlocks);
- //printk("MaxSectors = %x\n", Ssfdc.MaxSectors);
- //printk("MaxZones = %x\n", Ssfdc.MaxZones);
- //printk("bl_num = %x\n", bl_num);
+
+ /*
+ * printk("MaxLogBlocks = %x\n", Ssfdc.MaxLogBlocks);
+ * printk("MaxSectors = %x\n", Ssfdc.MaxSectors);
+ * printk("MaxZones = %x\n", Ssfdc.MaxZones);
+ * printk("bl_num = %x\n", bl_num);
+ */
us->bl_num = bl_num;
printk("bl_len = %x\n", bl_len);
printk("bl_num = %x\n", bl_num);
- //srb->request_bufflen = 8;
- buf[0] = (bl_num>>24) & 0xff;
- buf[1] = (bl_num>>16) & 0xff;
- buf[2] = (bl_num>> 8) & 0xff;
- buf[3] = (bl_num>> 0) & 0xff;
- buf[4] = (bl_len>>24) & 0xff;
- buf[5] = (bl_len>>16) & 0xff;
- buf[6] = (bl_len>> 8) & 0xff;
- buf[7] = (bl_len>> 0) & 0xff;
-
+ buf[0] = (bl_num >> 24) & 0xff;
+ buf[1] = (bl_num >> 16) & 0xff;
+ buf[2] = (bl_num >> 8) & 0xff;
+ buf[3] = (bl_num >> 0) & 0xff;
+ buf[4] = (bl_len >> 24) & 0xff;
+ buf[5] = (bl_len >> 16) & 0xff;
+ buf[6] = (bl_len >> 8) & 0xff;
+ buf[7] = (bl_len >> 0) & 0xff;
+
usb_stor_access_xfer_buf(us, buf, 8, srb, &sg, &offset, TO_XFER_BUF);
- //usb_stor_set_xfer_buf(us, buf, srb->request_bufflen, srb, TO_XFER_BUF);
+ /*
+ * usb_stor_set_xfer_buf(us, buf, srb->request_bufflen,
+ * srb, TO_XFER_BUF);
+ */
return USB_STOR_TRANSPORT_GOOD;
}
-//----- SM_SCSI_Read() --------------------------------------------------
int SM_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb)
{
- //struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *) us->iobuf;
- int result=0;
- PBYTE Cdb = srb->cmnd;
- DWORD bn = ((Cdb[2]<<24) & 0xff000000) | ((Cdb[3]<<16) & 0x00ff0000) |
- ((Cdb[4]<< 8) & 0x0000ff00) | ((Cdb[5]<< 0) & 0x000000ff);
- WORD blen = ((Cdb[7]<< 8) & 0xff00) | ((Cdb[8]<< 0) & 0x00ff);
- DWORD blenByte = blen * 0x200;
- void *buf;
-
- //printk("SCSIOP_READ --- bn = %X, blen = %X, srb->use_sg = %X\n", bn, blen, srb->use_sg);
-
+ /* struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *) us->iobuf; */
+ int result = 0;
+ PBYTE Cdb = srb->cmnd;
+ DWORD bn =
+ ((Cdb[2] << 24) & 0xff000000) | ((Cdb[3] << 16) & 0x00ff0000) |
+ ((Cdb[4] << 8) & 0x0000ff00) | ((Cdb[5] << 0) & 0x000000ff);
+ WORD blen = ((Cdb[7] << 8) & 0xff00) | ((Cdb[8] << 0) & 0x00ff);
+ DWORD blenByte = blen * 0x200;
+ void *buf;
+
+ /*
+ * printk("SCSIOP_READ --- bn = %X, blen = %X, srb->use_sg = %X\n",
+ * bn, blen, srb->use_sg);
+ */
+
if (bn > us->bl_num)
return USB_STOR_TRANSPORT_ERROR;
@@ -159,19 +166,22 @@ int SM_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb)
return USB_STOR_TRANSPORT_GOOD;
}
-//----- SM_SCSI_Write() --------------------------------------------------
int SM_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb)
{
- //struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *) us->iobuf;
- int result=0;
- PBYTE Cdb = srb->cmnd;
- DWORD bn = ((Cdb[2]<<24) & 0xff000000) | ((Cdb[3]<<16) & 0x00ff0000) |
- ((Cdb[4]<< 8) & 0x0000ff00) | ((Cdb[5]<< 0) & 0x000000ff);
- WORD blen = ((Cdb[7]<< 8) & 0xff00) | ((Cdb[8]<< 0) & 0x00ff);
- DWORD blenByte = blen * 0x200;
- void *buf;
-
- //printk("SCSIOP_Write --- bn = %X, blen = %X, srb->use_sg = %X\n", bn, blen, srb->use_sg);
+ /* struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *) us->iobuf; */
+ int result = 0;
+ PBYTE Cdb = srb->cmnd;
+ DWORD bn =
+ ((Cdb[2] << 24) & 0xff000000) | ((Cdb[3] << 16) & 0x00ff0000) |
+ ((Cdb[4] << 8) & 0x0000ff00) | ((Cdb[5] << 0) & 0x000000ff);
+ WORD blen = ((Cdb[7] << 8) & 0xff00) | ((Cdb[8] << 0) & 0x00ff);
+ DWORD blenByte = blen * 0x200;
+ void *buf;
+
+ /*
+ * printk("SCSIOP_Write --- bn = %X, blen = %X, srb->use_sg = %X\n",
+ * bn, blen, srb->use_sg);
+ */
if (bn > us->bl_num)
return USB_STOR_TRANSPORT_ERROR;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
@ 2011-03-26 16:16 ` Ralf Thielow
2011-03-26 18:51 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 16:16 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ralf Thielow
Includes missing KERN_ facility level to printk().
Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
drivers/staging/keucr/smscsi.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index c3db085..20386ce 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
@@ -110,8 +110,8 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
*/
us->bl_num = bl_num;
- printk("bl_len = %x\n", bl_len);
- printk("bl_num = %x\n", bl_num);
+ printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
+ printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
buf[0] = (bl_num >> 24) & 0xff;
buf[1] = (bl_num >> 16) & 0xff;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
@ 2011-03-26 18:51 ` Joe Perches
2011-03-26 19:11 ` Ralf Thielow
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2011-03-26 18:51 UTC (permalink / raw)
To: Ralf Thielow; +Cc: gregkh, devel, linux-kernel
On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
> Includes missing KERN_ facility level to printk().
[]
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
[]
> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
> WORD bl_len;
> BYTE buf[8];
>
> - printk("SM_SCSI_Read_Capacity\n");
> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
There should not be a comma between KERN_<level> and format.
Compile tested?
> + printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
> + printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 18:51 ` Joe Perches
@ 2011-03-26 19:11 ` Ralf Thielow
2011-03-26 19:26 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 19:11 UTC (permalink / raw)
To: Joe Perches; +Cc: gregkh, devel, linux-kernel
Of course, the whole staging directory with "make clean
M=drivers/staging && make M=drivers/staging".
You're right. The "printk" function accept these but it's wrong.
Thanks
2011/3/26 Joe Perches <joe@perches.com>:
> On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
>> Includes missing KERN_ facility level to printk().
> []
>> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
> []
>> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
>> WORD bl_len;
>> BYTE buf[8];
>>
>> - printk("SM_SCSI_Read_Capacity\n");
>> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
>
> There should not be a comma between KERN_<level> and format.
>
> Compile tested?
>
>> + printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
>> + printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 19:11 ` Ralf Thielow
@ 2011-03-26 19:26 ` Joe Perches
2011-03-26 19:33 ` Ralf Thielow
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2011-03-26 19:26 UTC (permalink / raw)
To: Ralf Thielow; +Cc: devel, gregkh, linux-kernel
On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote:
> Of course, the whole staging directory with "make clean
> M=drivers/staging && make M=drivers/staging".
> You're right. The "printk" function accept these but it's wrong.
Then you didn't really compile test it.
I suggest you check your compilation commands.
For instance:
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index 6211686..dd3cf95 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
$ make drivers/staging/keucr/smscsi.o
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC drivers/staging/keucr/smscsi.o
drivers/staging/keucr/smscsi.c: In function ‘SM_SCSI_Read_Capacity’:
drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
2011-03-26 19:26 ` Joe Perches
@ 2011-03-26 19:33 ` Ralf Thielow
0 siblings, 0 replies; 7+ messages in thread
From: Ralf Thielow @ 2011-03-26 19:33 UTC (permalink / raw)
To: Joe Perches; +Cc: devel, gregkh, linux-kernel
Ooops, i thougth i can trust "make M=***".
Thanks!
2011/3/26 Joe Perches <joe@perches.com>:
> On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote:
>> Of course, the whole staging directory with "make clean
>> M=drivers/staging && make M=drivers/staging".
>> You're right. The "printk" function accept these but it's wrong.
>
> Then you didn't really compile test it.
> I suggest you check your compilation commands.
>
> For instance:
>
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
> index 6211686..dd3cf95 100644
> --- a/drivers/staging/keucr/smscsi.c
> +++ b/drivers/staging/keucr/smscsi.c
> @@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
> WORD bl_len;
> BYTE buf[8];
>
> - printk("SM_SCSI_Read_Capacity\n");
> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
>
> bl_len = 0x200;
> bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
>
> $ make drivers/staging/keucr/smscsi.o
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CC drivers/staging/keucr/smscsi.o
> drivers/staging/keucr/smscsi.c: In function ‘SM_SCSI_Read_Capacity’:
> drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-04-20 20:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-26 19:21 [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-04-20 20:48 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-03-26 18:51 ` Joe Perches
2011-03-26 19:11 ` Ralf Thielow
2011-03-26 19:26 ` Joe Perches
2011-03-26 19:33 ` Ralf Thielow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox