Re: [PATCH 0/6] writeback: moving expire targets for background/kupdate works

Dave Chinner
2011-04-19T06:38:41Z

On Tue, Apr 19, 2011 at 11:00:03AM +0800, Wu Fengguang wrote:
>
> Andrew,
>
> This aims to reduce possible pageout() calls by making the flusher
> concentrate a bit more on old/expired dirty inodes.

In what situation is this a problem? Can you demonstrate how you
trigger it? And then how much improvement does this patchset make?

> Patches 04, 05 have been updated since last post, please review.
> The concerns from last review have been addressed.
>
> It runs fine on simple workloads over ext3/4, xfs, btrfs and NFS.

But it starts propagating new differences between background and
kupdate style writeback. We've been trying to reduce the number of
permutations of writeback behaviour, so it seems to me to be wrong
to further increase the behavioural differences. Indeed, why do we
need "for kupdate" style writeback and "background" writeback
anymore - can' we just use background style writeback for both?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com