From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
John Reiser <jreiser@bitwagon.com>
Subject: [RFC][PATCH 04/11] ftrace/recordmcount: Modify only executable sections
Date: Wed, 20 Apr 2011 22:28:29 -0400 [thread overview]
Message-ID: <20110421023737.991485123@goodmis.org> (raw)
In-Reply-To: 20110421022825.535486725@goodmis.org
[-- Attachment #1: 0004-ftrace-recordmcount-Modify-only-executable-sections.patch --]
[-- Type: text/plain, Size: 806 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
PROGBITS is not enough to determine if the section should be modified
or not. Only process sections that are marked as executable.
Cc: John Reiser <jreiser@bitwagon.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
scripts/recordmcount.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index ac7b330..7f8d5c4 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -360,6 +360,7 @@ __has_rel_mcount(Elf_Shdr const *const relhdr, /* is SHT_REL or SHT_RELA */
succeed_file();
}
if (w(txthdr->sh_type) != SHT_PROGBITS ||
+ !(w(txthdr->sh_flags) & SHF_EXECINSTR) ||
!is_mcounted_section_name(txtname))
return NULL;
return txtname;
--
1.7.2.3
next prev parent reply other threads:[~2011-04-21 2:37 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 2:28 [RFC][PATCH 00/11] ftrace/recordmcount: Remove useless mcount calls not being traced Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 01/11] ftrace/trivial: Clean up recordmcount.c to use Linux style comparisons Steven Rostedt
2011-04-21 8:46 ` Alan Cox
2011-04-21 11:36 ` Steven Rostedt
2011-04-21 12:28 ` Steven Rostedt
2011-04-22 15:09 ` John Reiser
2011-04-22 15:52 ` Thiago Farina
2011-04-22 16:05 ` Steven Rostedt
2011-04-26 18:52 ` Thiago Farina
2011-04-26 19:09 ` Steven Rostedt
2011-04-22 16:13 ` Steven Rostedt
2011-04-22 17:40 ` John Reiser
2011-04-22 17:56 ` H. Peter Anvin
2011-05-18 18:31 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:04 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 02/11] ftrace/trivial: Clean up record mcount to use Linux switch style Steven Rostedt
2011-05-18 18:31 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:04 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 03/11] ftrace: Add .kprobe.text section to whitelist for recordmcount.c Steven Rostedt
2011-05-18 18:32 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:05 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` Steven Rostedt [this message]
2011-05-18 18:32 ` [tip:perf/core] ftrace/recordmcount: Modify only executable sections tip-bot for Steven Rostedt
2011-06-16 14:05 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 05/11] ftrace/recordmcount: Make ignored mcount calls into nops at compile time Steven Rostedt
2011-05-18 18:32 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:05 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 06/11] ftrace/recordmcount: Add warning logic to warn on mcount not recorded Steven Rostedt
2011-05-18 18:33 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:06 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 07/11] kbuild/recordmcount: Add RECORDMCOUNT_WARN to warn about mcount callers Steven Rostedt
2011-04-21 2:40 ` Steven Rostedt
2011-04-21 20:40 ` Michal Marek
2011-04-26 19:08 ` Steven Rostedt
2011-05-18 18:33 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:06 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 08/11] ftrace: Avoid recording mcount on .init sections directly Steven Rostedt
2011-05-18 18:34 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:07 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 09/11] ftrace/x86: Do not trace .discard.text section Steven Rostedt
2011-05-18 18:34 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:07 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 10/11] ftrace/recordmcount: Remove duplicate code to find mcount symbol Steven Rostedt
2011-05-18 18:34 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:07 ` tip-bot for Steven Rostedt
2011-04-21 2:28 ` [RFC][PATCH 11/11] ftrace/recordmcount: Add helper function get_sym_str_and_relp() Steven Rostedt
2011-05-18 18:35 ` [tip:perf/core] " tip-bot for Steven Rostedt
2011-06-16 14:08 ` tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421023737.991485123@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jreiser@bitwagon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox