From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630Ab1DUMxy (ORCPT ); Thu, 21 Apr 2011 08:53:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127Ab1DUMxx (ORCPT ); Thu, 21 Apr 2011 08:53:53 -0400 Date: Thu, 21 Apr 2011 08:53:45 -0400 From: Don Zickus To: Cyrill Gorcunov Cc: Lin Ming , Ingo Molnar , lkml Subject: Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow Message-ID: <20110421125345.GC31724@redhat.com> References: <4DAEF821.4050103@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DAEF821.4050103@openvz.org> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote: > It's not enough to simply disable event on overflow the cpuc->active_mask > should be cleared as well otherwise counter may stall in "active" even > in real being already disabled (which potentially may lead to the situation > that user may not use this counter further). I also noticed this patch fixed some unknown NMIs on a P4 when I stressed the box Acked-by: Don Zickus