public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: David Daney <ddaney@caviumnetworks.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	BorislavPetkov <bp@alien8.de>
Subject: Re: annoying new gcc 4.6.0 warnings.
Date: Thu, 21 Apr 2011 15:58:02 -0400	[thread overview]
Message-ID: <20110421195801.GA15126@redhat.com> (raw)
In-Reply-To: <1303415086.24766.84.camel@Joe-Laptop>

On Thu, Apr 21, 2011 at 12:44:46PM -0700, Joe Perches wrote:
 > On Thu, 2011-04-21 at 12:39 -0700, David Daney wrote:
 > > Would it make any sense to add a config option to enable the spew for 
 > > those that wanted to see it?
 > 
 > Add it to make W=1 instead?
 > See commit 4a5838ad9d2d

This patch does that. Though I question the usefulness of W=1.
I just built powernow-k8.o with W=1, and got 4030 lines of output.
That's just insane.

	Dave

--

Disable the new -Wunused-but-set-variable that was added in gcc 4.6.0
It produces more false positives than useful warnings.

This can still be enabled using W=1

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/Makefile b/Makefile
index b967b96..68f178e 100644
--- a/Makefile
+++ b/Makefile
@@ -359,7 +359,8 @@ KBUILD_CFLAGS   := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
 		   -fno-strict-aliasing -fno-common \
 		   -Werror-implicit-function-declaration \
 		   -Wno-format-security \
-		   -fno-delete-null-pointer-checks
+		   -fno-delete-null-pointer-checks \
+		   -Wno-unused-but-set-variable
 KBUILD_AFLAGS_KERNEL :=
 KBUILD_CFLAGS_KERNEL :=
 KBUILD_AFLAGS   := -D__ASSEMBLY__
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index d5f925a..30627ab 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -79,6 +79,7 @@ KBUILD_EXTRA_WARNINGS += -Wpointer-arith
 KBUILD_EXTRA_WARNINGS += -Wredundant-decls
 KBUILD_EXTRA_WARNINGS += -Wshadow
 KBUILD_EXTRA_WARNINGS += -Wswitch-default
+KBUILD_EXTRA_WARNINGS += -Wunused-but-set-variable
 KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wvla,)
 KBUILD_CFLAGS += $(KBUILD_EXTRA_WARNINGS)
 endif


  reply	other threads:[~2011-04-21 19:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 19:21 annoying new gcc 4.6.0 warnings Dave Jones
2011-04-21 19:24 ` Linus Torvalds
2011-04-21 19:39   ` David Daney
2011-04-21 19:44     ` Joe Perches
2011-04-21 19:58       ` Dave Jones [this message]
2011-04-21 20:08         ` Sam Ravnborg
2011-04-21 20:27           ` Dave Jones
2011-04-21 20:37             ` David Daney
2011-04-21 20:45               ` Dave Jones
2011-04-21 20:56                 ` Sam Ravnborg
2011-04-21 21:28                   ` Dave Jones
2011-04-21 21:42                     ` Sam Ravnborg
2011-04-29 15:02                     ` Michal Marek
2011-04-21 20:09         ` Linus Torvalds
2011-04-21 20:15           ` Dave Jones
2011-04-21 20:30 ` Stratos Psomadakis
2011-04-21 21:10   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421195801.GA15126@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=ddaney@caviumnetworks.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox