From: NeilBrown <neilb@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] raid5: fix build error, sector_t usage
Date: Fri, 22 Apr 2011 11:14:29 +1000 [thread overview]
Message-ID: <20110422111429.3437b69a@notabene.brown> (raw)
In-Reply-To: <20110421090726.fffd8a5f.randy.dunlap@oracle.com>
On Thu, 21 Apr 2011 09:07:26 -0700 Randy Dunlap <randy.dunlap@oracle.com>
wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Change <sectors> from unsigned long long to sector_t.
> This matches its source field.
>
> ERROR: "__udivdi3" [drivers/md/raid456.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/md/raid5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20110421.orig/drivers/md/raid5.c
> +++ linux-next-20110421/drivers/md/raid5.c
> @@ -5678,7 +5678,7 @@ static void raid5_quiesce(mddev_t *mddev
> static void *raid45_takeover_raid0(mddev_t *mddev, int level)
> {
> struct raid0_private_data *raid0_priv = mddev->private;
> - unsigned long long sectors;
> + sector_t sectors;
>
> /* for raid0 takeover only one zone is supported */
> if (raid0_priv->nr_strip_zones > 1) {
Thanks Randy!
Linus: You can either apply this patch directly or pull again from my
for-linus branch.
The following changes since commit 28a8397852011e323d16a1eecd4787d72b7b9a9e:
md: Update documentation for sync_min and sync_max entries (2011-04-20 15:40:01 +1000)
are available in the git repository at:
git://neil.brown.name/md/ for-linus
Randy Dunlap (1):
raid5: fix build error, sector_t usage
drivers/md/raid5.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, and apologies,
NeilBrown
prev parent reply other threads:[~2011-04-22 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 14:01 [build bug] recent raid pull request? Ingo Molnar
2011-04-21 16:07 ` [PATCH] raid5: fix build error, sector_t usage Randy Dunlap
2011-04-22 1:14 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422111429.3437b69a@notabene.brown \
--to=neilb@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox