From: Yong Zhang <yong.zhang0@gmail.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] sched: remove noop in alloc_rt_sched_group()
Date: Sat, 23 Apr 2011 22:12:22 +0800 [thread overview]
Message-ID: <20110423141222.GB7747@zhy> (raw)
In-Reply-To: <BANLkTin-FfQfqW5ym1iuEmrk8s777Y1LAg@mail.gmail.com>
On Sat, Apr 23, 2011 at 09:29:05PM +0800, Hillf Danton wrote:
> The rq varible, though computed for each possible cpu, has nothing to
> do in the function, so it could be removed.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
Looks good.
Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>
> ---
>
> --- a/kernel/sched.c 2011-03-30 03:09:48.000000000 +0800
> +++ b/kernel/sched.c 2011-04-23 21:23:48.000000000 +0800
> @@ -8539,7 +8539,6 @@ int alloc_rt_sched_group(struct task_gro
> {
> struct rt_rq *rt_rq;
> struct sched_rt_entity *rt_se;
> - struct rq *rq;
> int i;
>
> tg->rt_rq = kzalloc(sizeof(rt_rq) * nr_cpu_ids, GFP_KERNEL);
> @@ -8553,8 +8552,6 @@ int alloc_rt_sched_group(struct task_gro
> ktime_to_ns(def_rt_bandwidth.rt_period), 0);
>
> for_each_possible_cpu(i) {
> - rq = cpu_rq(i);
> -
> rt_rq = kzalloc_node(sizeof(struct rt_rq),
> GFP_KERNEL, cpu_to_node(i));
> if (!rt_rq)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-04-23 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-23 13:29 [PATCH] sched: remove noop in alloc_rt_sched_group() Hillf Danton
2011-04-23 14:12 ` Yong Zhang [this message]
2011-04-26 12:58 ` [tip:sched/core] sched: Remove " tip-bot for Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110423141222.GB7747@zhy \
--to=yong.zhang0@gmail.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).