linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]Remove a warning
@ 2011-04-26  4:38 Harry Wei
  2011-04-26  7:07 ` Harry Wei
  2011-04-26 16:47 ` Randy Dunlap
  0 siblings, 2 replies; 4+ messages in thread
From: Harry Wei @ 2011-04-26  4:38 UTC (permalink / raw)
  To: linux-kernel; +Cc: greg, joe, randy.dunlap, akpm

Hi us,
   When i was compiling kernel, a warning happened to me.
The warning said like following.

drivers/staging/wlan-ng/cfg80211.c:709: warning: initialization from 
incompatible pointer type

So i patched like this.

From: Harry Wei <harryxiyou@gmail.com>

Signed-off-by: Harry Wei <harryxiyou@gmail.com>
---
 drivers/staging/wlan-ng/cfg80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 6a71f52..7637839 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -273,7 +273,7 @@ exit:
 }
 
 int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
-			   u8 key_index)
+			   u8 key_index, bool unicast, bool multicast)
 {
 	wlandevice_t *wlandev = dev->ml_priv;
 
-- 
1.7.0.4




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH]Remove a warning
  2011-04-26  4:38 [PATCH]Remove a warning Harry Wei
@ 2011-04-26  7:07 ` Harry Wei
  2011-04-26 13:08   ` Wanlong Gao
  2011-04-26 16:47 ` Randy Dunlap
  1 sibling, 1 reply; 4+ messages in thread
From: Harry Wei @ 2011-04-26  7:07 UTC (permalink / raw)
  To: linux-kernel; +Cc: greg, akpm, joe, randy.dunlap

On Tue, Apr 26, 2011 at 12:38:37PM +0800, Harry Wei wrote:
> Hi us,
>    When i was compiling kernel, a warning happened to me.
> The warning said like following.
> 
> drivers/staging/wlan-ng/cfg80211.c:709: warning: initialization from 
> incompatible pointer type
See http://s1202.photobucket.com/albums/bb364/harrywei/?action=view&current=patched2.png
for more details.
> 
> So i patched like this.
> 
> From: Harry Wei <harryxiyou@gmail.com>
> 
> Signed-off-by: Harry Wei <harryxiyou@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 6a71f52..7637839 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -273,7 +273,7 @@ exit:
>  }
>  
>  int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
> -			   u8 key_index)
> +			   u8 key_index, bool unicast, bool multicast)
>  {
>  	wlandevice_t *wlandev = dev->ml_priv;
>  
> -- 
> 1.7.0.4
> 
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]Remove a warning
  2011-04-26  7:07 ` Harry Wei
@ 2011-04-26 13:08   ` Wanlong Gao
  0 siblings, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2011-04-26 13:08 UTC (permalink / raw)
  To: linux-kernel, greg, akpm, joe, randy.dunlap

>>On Tue, Apr 26, 2011 at 12:38:37PM +0800, Harry Wei wrote:

>> Signed-off-by: Harry Wei <harryxiyou@gmail.com>
>> ---
>>  drivers/staging/wlan-ng/cfg80211.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/wlan-ng/cfg80211.c
>> b/drivers/staging/wlan-ng/cfg80211.c
>> index 6a71f52..7637839 100644
>> --- a/drivers/staging/wlan-ng/cfg80211.c
>> +++ b/drivers/staging/wlan-ng/cfg80211.c
>> @@ -273,7 +273,7 @@ exit:
>>  }
>>
>>  int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
>> -			   u8 key_index)
>> +			   u8 key_index, bool unicast, bool multicast)
It seems can fix the warning .
Thanks
>>  {
>>  	wlandevice_t *wlandev = dev->ml_priv;
>>
>> --
>> 1.7.0.4
>>
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]Remove a warning
  2011-04-26  4:38 [PATCH]Remove a warning Harry Wei
  2011-04-26  7:07 ` Harry Wei
@ 2011-04-26 16:47 ` Randy Dunlap
  1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2011-04-26 16:47 UTC (permalink / raw)
  To: Harry Wei; +Cc: linux-kernel, greg, joe, randy.dunlap, akpm

On Tue, 26 Apr 2011 12:38:37 +0800 Harry Wei wrote:

> Hi us,
>    When i was compiling kernel, a warning happened to me.
> The warning said like following.
> 
> drivers/staging/wlan-ng/cfg80211.c:709: warning: initialization from 
> incompatible pointer type
> 
> So i patched like this.
> 
> From: Harry Wei <harryxiyou@gmail.com>
> 
> Signed-off-by: Harry Wei <harryxiyou@gmail.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.


> ---
>  drivers/staging/wlan-ng/cfg80211.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 6a71f52..7637839 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -273,7 +273,7 @@ exit:
>  }
>  
>  int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
> -			   u8 key_index)
> +			   u8 key_index, bool unicast, bool multicast)
>  {
>  	wlandevice_t *wlandev = dev->ml_priv;
>  
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-04-26 16:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-26  4:38 [PATCH]Remove a warning Harry Wei
2011-04-26  7:07 ` Harry Wei
2011-04-26 13:08   ` Wanlong Gao
2011-04-26 16:47 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).