linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Paul Mackerras <paulus@samba.org>,
	Pekka Enberg <penberg@kernel.org>,
	Vegard Nossum <vegardno@ifi.uio.no>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [BUG] perf and kmemcheck : fatal combination
Date: Tue, 26 Apr 2011 10:04:43 +0200	[thread overview]
Message-ID: <20110426080443.GA806@elte.hu> (raw)
In-Reply-To: <1303803525.20212.20.camel@twins>


* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Mon, 2011-04-25 at 18:08 +0200, Eric Dumazet wrote:
> > Hi guys
> > 
> > Just got a panic on a kmemcheck kernel, latest linux-2.6 tree.
> > 
> > I forgot I had kmemcheck enabled, and started "perf top" just because my
> > machine was damn slow... Oh well...
> > 
> > Crash in do_nmi -> nmi_enter() -> BUG_ON(in_nmi());
> 
> Hmm,. I bet because kmemcheck triggers faults from nmi context because
> it messes about with the page protection bits a lot to track things.
> 
> Can't really think of anything except not making perf available on
> kmemcheck kernels.
> 
> ---
>  init/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 32745bf..94735b4 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1125,6 +1125,7 @@ config PERF_EVENTS
>  	bool "Kernel performance events and counters"
>  	default y if (PROFILING || PERF_COUNTERS)
>  	depends on HAVE_PERF_EVENTS
> +	depends on !KMEMCHECK
>  	select ANON_INODES
>  	select IRQ_WORK
>  	help

Eric, does it manage to limp along if you remove the BUG_ON()?

That risks NMI recursion but maybe it allows you to see why things are slow, 
before it crashes ;-)

Thanks,

	Ingo

  parent reply	other threads:[~2011-04-26  8:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 16:08 [BUG] perf and kmemcheck : fatal combination Eric Dumazet
2011-04-26  7:38 ` Peter Zijlstra
2011-04-26  7:43   ` Pekka Enberg
2011-04-26  8:04   ` Ingo Molnar [this message]
2011-04-26  8:57     ` Eric Dumazet
2011-04-26  9:53       ` Eric Dumazet
2011-04-26 10:08         ` Pekka Enberg
2011-04-26 10:27           ` Eric Dumazet
2011-04-26 12:27             ` Eric Dumazet
2011-04-26 12:33               ` Peter Zijlstra
2011-04-26 12:56                 ` Eric Dumazet
2011-04-26 13:09                   ` Eric Dumazet
2011-04-26 19:13                 ` Pekka Enberg
2011-04-26 13:53         ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110426080443.GA806@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulus@samba.org \
    --cc=penberg@kernel.org \
    --cc=vegardno@ifi.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).