From: Samuel Ortiz <sameo@linux.intel.com>
To: Haojian Zhuang <haojian.zhuang@marvell.com>
Cc: haojian.zhuang@gmail.com, linux-kernel@vger.kernel.org,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH 08/14] mfd: use platform_data in max8925
Date: Tue, 26 Apr 2011 11:45:41 +0200 [thread overview]
Message-ID: <20110426094540.GC2659@sortiz-mobl> (raw)
In-Reply-To: <1303300466-1960-1-git-send-email-haojian.zhuang@marvell.com>
Hi Haojian,
On Wed, Apr 20, 2011 at 07:54:26PM +0800, Haojian Zhuang wrote:
> Use platform_data to pass parameters to client driver.
You need to provide more details about why this is needed, and how the sub
devices resources can change from one platform to another.
Also, some additional comments:
> +static struct resource bk_resources[] __devinitdata = {
> + {0, 0, "max8925-backlight", IORESOURCE_IO,},
> };
Do you really need to define this empty resource ? Can't you do that from the
device_*_init() routines ?
> +static void __devinit device_bk_init(struct max8925_chip *chip,
> + struct i2c_client *i2c,
> + struct max8925_platform_data *pdata)
I don't think you need to pass the i2c pointer here.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-04-26 9:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2011041801>
2011-04-18 14:03 ` [PATCH v2 00/14] Update 88pm860x and max8925 MFD driver Haojian Zhuang
2011-04-18 14:03 ` [PATCH 01/14] input: touchscreen: use polling mode in 88pm860x Haojian Zhuang
2011-04-18 14:03 ` [PATCH 02/14] input: touchscreen: move initialization " Haojian Zhuang
2011-04-26 8:57 ` Samuel Ortiz
2011-04-18 14:04 ` [PATCH 03/14] rtc: add 88pm860x rtc Haojian Zhuang
2011-04-26 8:58 ` Samuel Ortiz
2011-04-18 14:04 ` [PATCH 04/14] input: set the long press detection in 88pm860x onkey Haojian Zhuang
2011-04-18 14:04 ` [PATCH 05/14] w1: add DS278x slave driver Haojian Zhuang
2011-04-18 14:04 ` [PATCH 06/14] mfd: pxa-w1: MFD driver for PXA 1wire control + DS1WM chip Haojian Zhuang
2011-04-26 9:48 ` Samuel Ortiz
2011-05-14 14:21 ` Haojian Zhuang
2011-05-14 19:40 ` Russell King - ARM Linux
2011-05-14 22:23 ` Mark Brown
2011-05-22 20:00 ` Samuel Ortiz
2011-04-18 14:04 ` [PATCH 07/14] mfd: fix build warning on 88pm860x Haojian Zhuang
2011-04-26 9:49 ` Samuel Ortiz
2011-04-26 16:44 ` Haojian Zhuang
2011-04-26 16:47 ` Samuel Ortiz
2011-04-18 14:04 ` [PATCH 08/14] mfd: use platform_data in max8925 Haojian Zhuang
2011-04-20 11:54 ` Haojian Zhuang
2011-04-26 9:45 ` Samuel Ortiz [this message]
2011-04-18 14:04 ` [PATCH 09/14] input: get irq from resource in max8925 onkey Haojian Zhuang
2011-04-18 14:04 ` [PATCH 10/14] rtc: avoid to use hardcoding irq number in max8925 Haojian Zhuang
2011-04-18 14:04 ` [PATCH 11/14] power_supply: max8925: use platform_data from cell Haojian Zhuang
2011-04-18 21:49 ` Anton Vorontsov
2011-05-02 15:15 ` Samuel Ortiz
2011-04-18 14:04 ` [PATCH 12/14] regulator: max8925: enable i2c sequence for control Haojian Zhuang
2011-04-18 14:27 ` Mark Brown
2011-05-02 15:16 ` Samuel Ortiz
2011-04-18 14:04 ` [PATCH 13/14] regulator: check name in initialization of max8925 Haojian Zhuang
2011-04-18 14:28 ` Mark Brown
2011-04-18 15:33 ` Haojian Zhuang
2011-04-18 16:04 ` Mark Brown
2011-04-19 2:42 ` Haojian Zhuang
2011-04-19 8:09 ` Mark Brown
2011-04-19 8:28 ` Haojian Zhuang
2011-04-19 10:51 ` Mark Brown
2011-04-19 11:33 ` Haojian Zhuang
2011-04-20 11:55 ` [PATCH 13/14] regulator: max8925: fix not add device if missing init data Haojian Zhuang
2011-04-21 10:42 ` Mark Brown
2011-04-21 11:13 ` Haojian Zhuang
2011-04-21 12:03 ` Mark Brown
2011-04-21 15:23 ` Haojian Zhuang
2011-04-21 18:32 ` Mark Brown
2011-04-18 14:04 ` [PATCH 14/14] regulator: 88pm8607: avoid to use constraint name in driver Haojian Zhuang
2011-04-18 14:30 ` Mark Brown
2011-04-18 15:38 ` Haojian Zhuang
2011-04-18 16:02 ` Mark Brown
2011-04-19 2:45 ` Haojian Zhuang
2011-04-19 8:13 ` Mark Brown
2011-04-19 11:34 ` Haojian Zhuang
2011-04-20 11:56 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426094540.GC2659@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=haojian.zhuang@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).