From: Ingo Molnar <mingo@elte.hu>
To: Mike Travis <travis@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Jack Steiner <steiner@sgi.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] memblock: add error return when CONFIG_HAVE_MEMBLOCK is not set
Date: Wed, 27 Apr 2011 08:33:18 +0200 [thread overview]
Message-ID: <20110427063318.GC17079@elte.hu> (raw)
In-Reply-To: <4DB6FBC2.7000806@sgi.com>
* Mike Travis <travis@sgi.com> wrote:
>
>
> Andrew Morton wrote:
> >On Mon, 25 Apr 2011 13:11:37 -0500
> >Mike Travis <travis@sgi.com> wrote:
> >
> >> Add an error return if CONFIG_HAVE_MEMBLOCK is not set instead
> >> of having to add #ifdef CONFIG_HAVE_MEMBLOCK around blocks of
> >> code calling that function.
> >>
> >>Authored-by: Yinghai Lu <yinghai@kernel.org>
> >>Signed-off-by: Mike Travis <travis@sgi.com>
> >
> >There is no such thing as "Authored-by:". If this patch was written by
> >yinghai then it must be tagged as From:him at the top of the changelog
> >and preferably has his signed-off-by: at the end.
> >
> >Please clarify?
>
> Yes, you have it correct. I had added the From: line but when I receive
> the email, it's removed.
>
> Why not have an "Authored-by"? That would eliminate the sendmail program
> from screwing it up?
"From:" headers are properly recognized by Git and both git log and git
annotate will show the right authorship. Authored-by does not get propagated.
Also, sendmail does not screw up From: headers that are in the body of the
email - forwarding emails is one of the oldest things that can be done to
emails.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-27 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 18:11 [PATCH 0/2] printk: Allocate log buffer as early as possible Mike Travis
2011-04-25 18:11 ` [PATCH 1/2] memblock: add error return when CONFIG_HAVE_MEMBLOCK is not set Mike Travis
2011-04-25 22:48 ` Andrew Morton
2011-04-26 17:07 ` Mike Travis
2011-04-27 6:33 ` Ingo Molnar [this message]
2011-04-29 14:08 ` Valdis.Kletnieks
2011-04-25 18:11 ` [PATCH 2/2] printk: Allocate kernel log buffer earlier v2 Mike Travis
2011-04-26 8:06 ` [PATCH 0/2] printk: Allocate log buffer as early as possible Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2011-02-25 18:06 [PATCH 0/4] init: Shrink early messages to prevent overflowing the kernel log buffer Mike Travis
2011-02-25 18:06 ` [PATCH 1/4] printk: Allocate kernel log buffer earlier Mike Travis
2011-02-27 12:09 ` Ingo Molnar
2011-02-27 12:15 ` Ingo Molnar
2011-02-28 1:34 ` Yinghai Lu
2011-02-28 19:23 ` Mike Travis
2011-02-28 19:46 ` Yinghai Lu
2011-02-28 20:02 ` Mike Travis
2011-02-28 22:59 ` Yinghai Lu
2011-03-31 0:41 ` [PATCH 1/2] memblock: add error return when CONFIG_HAVE_MEMBLOCK is not set Mike Travis
2011-03-31 1:40 ` Yinghai Lu
2011-03-31 15:23 ` Mike Travis
2011-03-31 16:17 ` Yinghai Lu
2011-04-07 19:43 ` Mike Travis
2011-04-08 6:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427063318.GC17079@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox