From: Stephen Hemminger <shemminger@vyatta.com>
To: artpol <artpol84@gmail.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.38.4] mii: add support of pause frames in mii_get_an
Date: Wed, 27 Apr 2011 21:49:02 -0700 [thread overview]
Message-ID: <20110427214902.0826a4d1@nehalam> (raw)
In-Reply-To: <1303962554.15395.1.camel@artpol-thinkpad>
On Thu, 28 Apr 2011 10:49:14 +0700
artpol <artpol84@gmail.com> wrote:
> Add support of pause frames advertise in mii_get_an. This provides all drivers
> that use mii_ethtool_gset to represent their own and Link partner flow control
> abilities in ethtool.
>
> Signed-off-by: Artem Polyakov <artpol84@gmail.com>
>
> ---
>
> --- linux-2.6.38.4/drivers/net/mii.c.orig 2011-04-28 08:46:13.000000000 +0700
> +++ linux-2.6.38.4/drivers/net/mii.c 2011-04-25 23:04:20.694981968 +0700
> @@ -49,6 +49,10 @@ static u32 mii_get_an(struct mii_if_info
> result |= ADVERTISED_100baseT_Half;
> if (advert & ADVERTISE_100FULL)
> result |= ADVERTISED_100baseT_Full;
> + if (advert & ADVERTISE_PAUSE_CAP)
> + result |= ADVERTISED_Pause;
> + if (advert & ADVERTISE_PAUSE_ASYM)
> + result |= ADVERTISED_Asym_Pause;
>
> return result;
> }
One common driver problem is that auto negotiation of pause
is really a separate operation from negotiation of speed.
It should be possible to force no flow-control but still negotiate
speed and vice-versa. The ethtool api breaks this into two operations
but many drivers munge them together.
next prev parent reply other threads:[~2011-04-28 4:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 3:49 [PATCH 2.6.38.4] mii: add support of pause frames in mii_get_an artpol
2011-04-28 4:49 ` Stephen Hemminger [this message]
2011-04-28 12:45 ` Ben Hutchings
2011-04-29 20:57 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-04-28 2:15 artpol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427214902.0826a4d1@nehalam \
--to=shemminger@vyatta.com \
--cc=artpol84@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox