From: Greg KH <gregkh@suse.de>
To: "Weil, Oren jer" <oren.jer.weil@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"david@woodhou.se" <david@woodhou.se>
Subject: Re: [PATCH 7/8] staging/mei: AMT Watchdog
Date: Thu, 28 Apr 2011 06:38:30 -0700 [thread overview]
Message-ID: <20110428133830.GB4861@suse.de> (raw)
In-Reply-To: <F28B59AD52D84B479DCA469824475335065AF92EC7@hasmsx503.ger.corp.intel.com>
On Thu, Apr 28, 2011 at 08:51:41AM +0300, Weil, Oren jer wrote:
> >On Wed, Apr 27, 2011 at 03:53:01PM +0200, Arnd Bergmann wrote:
> >> I still think this should be a regular watchdog driver using the
> >> drivers/watchdog user interface.
> >
> >I agree, Oren, if you are going to insist on doing things this way, you had
> >better describe _why_ you are ignoring the existing kernel interfaces
> >provided.
>
> we are not going to ignore the existing interfaces, it is one of our items
> in the TODO list.
Like I stated earlier, there was no TODO list in your patch, so how
could we know this? :)
> You can see the we move all of the Watchdog code to a single file so it
> would easy to us to take it later to other driver.
> Another Item on our TODO list is to expose Kernel function that equivalent
> to user interface so kernel clients can access FW features/clients.
Nice, but again, how could we know this?
thanks,
greg k-h
next prev parent reply other threads:[~2011-04-28 13:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 10:27 [PATCH 0/8] staging/mei: Intel MEI Driver Oren Weil
2011-04-27 10:27 ` [PATCH 1/8] staging/mei: PCI device and char driver support Oren Weil
2011-04-27 12:24 ` Jiri Slaby
2011-04-27 15:05 ` Greg KH
2011-04-28 5:47 ` Weil, Oren jer
2011-04-28 13:37 ` Greg KH
2011-04-27 10:27 ` [PATCH 2/8] staging/mei: Interrupt handling Oren Weil
2011-04-27 10:27 ` [PATCH 3/8] staging/mei: MEI "Link" layer code - MEI Hardware communications Oren Weil
2011-04-27 15:18 ` Greg KH
2011-04-27 10:27 ` [PATCH 4/8] staging/mei: MEI driver init flow Oren Weil
2011-04-27 10:27 ` [PATCH 5/8] staging/mei: Hardware and MEI driver internal struct definition Oren Weil
2011-04-27 10:27 ` [PATCH 6/8] staging/mei: Header file contain the Userland API, (IOCTL and its struct) Oren Weil
2011-04-27 15:02 ` Greg KH
2011-04-27 15:15 ` Randy Dunlap
2011-04-27 15:33 ` Greg KH
2011-04-28 6:29 ` Weil, Oren jer
2011-04-28 13:40 ` Greg KH
2011-04-28 14:12 ` Weil, Oren jer
2011-04-28 15:04 ` Greg KH
2011-04-28 15:39 ` David Woodhouse
2011-04-28 14:43 ` Alan Cox
2011-04-27 10:27 ` [PATCH 7/8] staging/mei: AMT Watchdog Oren Weil
2011-04-27 13:53 ` Arnd Bergmann
2011-04-27 15:07 ` Greg KH
2011-04-28 5:51 ` Weil, Oren jer
2011-04-28 12:50 ` Arnd Bergmann
2011-04-28 13:38 ` Greg KH [this message]
2011-04-27 10:27 ` [PATCH 8/8] staging/mei: Updates to staging/Kconfig ane staging/Makefile and a new Makefile and Kconfig Oren Weil
2011-04-27 15:06 ` Greg KH
2011-04-28 6:39 ` Weil, Oren jer
2011-04-28 8:22 ` Alan Cox
2011-04-27 15:19 ` Randy Dunlap
2011-04-28 0:05 ` Valdis.Kletnieks
2011-04-27 15:03 ` [PATCH 0/8] staging/mei: Intel MEI Driver Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428133830.GB4861@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=david@woodhou.se \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox