From: Ingo Molnar <mingo@elte.hu>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization
Date: Fri, 29 Apr 2011 11:44:41 +0200 [thread overview]
Message-ID: <20110429094441.GA22092@elte.hu> (raw)
In-Reply-To: <1304066518-30420-2-git-send-email-ming.m.lin@intel.com>
* Lin Ming <ming.m.lin@intel.com> wrote:
> pubname_callback_param::found should be initialized to 0 in fastpath lookup.
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> tools/perf/util/probe-finder.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index a7c7145..3b9d0b8 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
> .file = pp->file,
> .cu_die = &pf->cu_die,
> .sp_die = &pf->sp_die,
> + .found = 0,
Hm, why is this a 'misc cleanup'? If this field is uninitialized (it does
appear so) and we rely on the field then right now this is a bug and the fix
should be pushed to perf/urgent.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-29 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 8:41 [PATCH 0/2] perf misc cleanup Lin Ming
2011-04-29 8:41 ` [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization Lin Ming
2011-04-29 9:44 ` Ingo Molnar [this message]
2011-04-29 13:18 ` Lin Ming
2011-04-29 17:33 ` Arnaldo Carvalho de Melo
2011-04-30 4:14 ` Lin Ming
2011-05-10 13:43 ` Lin Ming
2011-05-10 20:13 ` [tip:perf/core] " tip-bot for Lin Ming
2011-04-29 8:41 ` [PATCH 2/2] perf annotate: Remove duplicate header file Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429094441.GA22092@elte.hu \
--to=mingo@elte.hu \
--cc=acme@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox