Re: [PATCH V2] kbuild: don't warn about include/linux/version.h not including itself

[Michal Marek <mmarek@suse.cz>]

On Tue, Apr 26, 2011 at 07:07:56PM -0400, Peter Foley wrote:
> This patch makes checkversion.pl not warn that include/linux/version.h
> dosen't include itself.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
>  scripts/checkversion.pl |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
> index b444e89..cf4b1dc 100755
> --- a/scripts/checkversion.pl
> +++ b/scripts/checkversion.pl
> @@ -12,6 +12,8 @@ $| = 1;
>  my $debugging;
>  
>  foreach my $file (@ARGV) {
> +    if($file !~ "include/linux/version\.h")
> +    {
>      # Open this file.

Enclosing the block in another pair of {...} is ugly, I changed it to


diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
index b444e89..5e490a8 100755
--- a/scripts/checkversion.pl
+++ b/scripts/checkversion.pl
@@ -12,6 +12,7 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    next if $file =~ "include/linux/version\.h";
     # Open this file.
     open( my $f, '<', $file )
       or die "Can't open $file: $!\n";

and pushed to kbuild-2.6.git#misc.

Michal