From: Tejun Heo <tj@kernel.org>
To: Thilo-Alexander Ginkel <thilo@ginkel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: Soft lockup during suspend since ~2.6.36 [bisected]
Date: Fri, 29 Apr 2011 18:00:39 +0200 [thread overview]
Message-ID: <20110429160039.GP16552@htj.dyndns.org> (raw)
In-Reply-To: <BANLkTinK3jZmKewkbtmOn54cRXhszh_5sQ@mail.gmail.com>
Hello,
On Fri, Apr 29, 2011 at 01:56:46AM +0200, Thilo-Alexander Ginkel wrote:
> On Thu, Apr 28, 2011 at 12:30, Tejun Heo <tj@kernel.org> wrote:
> > Does your kernel have preemption enabled?
>
> CONFIG_PREEMPT is not set
>
> > If not, does the following patch fix the problem?
>
> Yep, looks good so far (at least in my virtualized test environment):
> 2.6.39-rc4 with your patch applied survived 100 suspend/resume cycles
> w/o locking up.
Awesome, I'll forward the patch to mainline and -stable.
> Just out of curiosity: Was this a new issue in 2.6.39-rc4 ord could
> this fix be backported to 2.6.38?
This needs to be backported. It's an issue which has been there from
the initial implementation of cmwq. It needs non-preemptive kernel
and rescuer kicking in at a very bad timing, so not many people seem
to have been affected by this. Your setup somehow triggers it
reliably.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-04-29 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 18:56 Soft lockup during suspend since ~2.6.36 [bisected] Thilo-Alexander Ginkel
2011-04-05 23:28 ` Arnd Bergmann
2011-04-06 6:03 ` Thilo-Alexander Ginkel
2011-04-14 12:24 ` Thilo-Alexander Ginkel
2011-04-17 19:35 ` Arnd Bergmann
2011-04-17 21:53 ` Thilo-Alexander Ginkel
2011-04-26 13:11 ` Tejun Heo
2011-04-27 23:51 ` Thilo-Alexander Ginkel
2011-04-28 10:30 ` Tejun Heo
2011-04-28 23:56 ` Thilo-Alexander Ginkel
2011-04-29 16:00 ` Tejun Heo [this message]
2011-04-29 16:18 ` [PATCH] workqueue: fix deadlock in worker_maybe_bind_and_lock() Tejun Heo
2011-04-29 20:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429160039.GP16552@htj.dyndns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=thilo@ginkel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).