From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mike Waychison <mikew@google.com>
Cc: Greg KH <greg@kroah.com>, Matt Domsch <Matt_Domsch@dell.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Duncan Laurie <dlaurie@google.com>,
Aaron Durbin <adurbin@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Tim Hockin <thockin@google.com>, San Mehat <san@google.com>
Subject: Re: [PATCH v4 1/3] driver: Google EFI SMI
Date: Fri, 29 Apr 2011 16:47:36 -0700 [thread overview]
Message-ID: <20110429164736.fd84f2ae.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110429225551.22013.65012.stgit@mike.mtv.corp.google.com>
On Fri, 29 Apr 2011 15:55:51 -0700 Mike Waychison wrote:
> +static int gsmi_die_callback(struct notifier_block *nb,
> + unsigned long reason, void *arg)
> +{
> + if (reason == DIE_NMIWATCHDOG)
> + gsmi_shutdown_reason(GSMI_SHUTDOWN_NMIWDT);
> + else if (reason == DIE_OOPS)
> + gsmi_shutdown_reason(GSMI_SHUTDOWN_OOPS);
> + return NOTIFY_DONE;
> +}
Where is DIE_NMIWATCHDOG defined?
Do I need more that patches 1,2,3/3 applied?
lnx-2639-rc5/drivers/firmware/google/gsmi.c: In function 'gsmi_die_callback':
lnx-2639-rc5/drivers/firmware/google/gsmi.c:660: error: 'DIE_NMIWATCHDOG' undeclared (first use in this function)
lnx-2639-rc5/drivers/firmware/google/gsmi.c:660: error: (Each undeclared identifier is reported only once
lnx-2639-rc5/drivers/firmware/google/gsmi.c:660: error: for each function it appears in.)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-04-29 23:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 6:58 [PATCH v3 0/5] google firmware support Mike Waychison
2011-03-15 6:58 ` [PATCH v3 1/5] x86: get_bios_ebda_length() Mike Waychison
2011-04-19 23:50 ` Greg KH
2011-04-29 20:42 ` Greg KH
2011-03-15 6:58 ` [PATCH v3 2/5] x86: Better comments for get_bios_ebda() Mike Waychison
2011-03-15 6:58 ` [PATCH v3 3/5] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 21:23 ` Greg KH
2011-04-29 22:55 ` [PATCH v4 1/3] driver: Google EFI SMI Mike Waychison
2011-04-29 23:40 ` Greg KH
2011-04-30 0:14 ` Mike Waychison
2011-04-30 0:39 ` [PATCH v5 " Mike Waychison
2011-04-30 0:39 ` [PATCH v5 2/3] driver: Google Memory Console Mike Waychison
2011-04-30 0:39 ` [PATCH v5 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 23:47 ` Randy Dunlap [this message]
2011-04-29 23:59 ` [PATCH v4 1/3] driver: Google EFI SMI Mike Waychison
2011-04-29 22:55 ` [PATCH v4 2/3] driver: Google Memory Console Mike Waychison
2011-04-29 22:56 ` [PATCH v4 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-30 10:25 ` Alan Cox
2011-03-15 6:59 ` [PATCH v3 4/5] driver: Google EFI SMI Mike Waychison
2011-03-15 6:59 ` [PATCH v3 5/5] driver: Google Memory Console Mike Waychison
2011-03-15 7:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429164736.fd84f2ae.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Matt_Domsch@dell.com \
--cc=adurbin@google.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dlaurie@google.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=san@google.com \
--cc=thockin@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox