public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: johnlinn@comcast.net
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	alan@lxorguk.ukuu.org.uk, michal.simek@petalogix.com,
	joe@perches.com, grant.likely@secretlab.ca,
	John Linn <john.linn@xilinx.com>
Subject: Re: [PATCH V4] tty/serial: add support for Xilinx PS UART
Date: Fri, 29 Apr 2011 14:14:34 -0700	[thread overview]
Message-ID: <20110429211434.GA1355@kroah.com> (raw)
In-Reply-To: <beef0ca4-f7d3-4f61-b22a-d9eeeb0618f4@VA3EHSMHS010.ehs.local>

On Wed, Apr 27, 2011 at 12:17:36PM -0600, johnlinn@comcast.net wrote:
> From: John Linn <john.linn@xilinx.com>
> 
> The Xilinx PS Uart is used on the new ARM based SoC. This
> UART is not compatible with others such that a seperate
> driver is required.
> 
> Signed-off-by: John Linn <john.linn@xilinx.com>

I get build failures with this patch:

  CC [M]  drivers/tty/serial/xilinx_uartps.o
drivers/tty/serial/xilinx_uartps.c: In function ‘xuartps_get_port’:
drivers/tty/serial/xilinx_uartps.c:785:14: error: ‘NO_IRQ’ undeclared (first use in this function)
drivers/tty/serial/xilinx_uartps.c:785:14: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [drivers/tty/serial/xilinx_uartps.o] Error 1

Care to fix this up so it's in a state I can properly apply it to the
tree?

thanks,

greg k-h

  parent reply	other threads:[~2011-04-29 21:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 18:17 [PATCH V4] tty/serial: add support for Xilinx PS UART johnlinn
2011-04-27 20:40 ` Alan Cox
2011-04-27 20:57   ` johnlinn
2011-04-29 21:14 ` Greg KH [this message]
2011-04-29 21:29   ` johnlinn
2011-04-29 21:32     ` Alan Cox
2011-04-29 21:41       ` johnlinn
2011-05-06 12:11         ` Michal Simek
2011-05-06 12:23           ` Alan Cox
2011-05-06 16:41             ` Grant Likely
2011-04-29 22:02   ` johnlinn
2011-04-29 23:29     ` Greg KH
     [not found] <681890114.2094084.1304112868616.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
2011-04-29 21:35 ` johnlinn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429211434.GA1355@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=grant.likely@secretlab.ca \
    --cc=joe@perches.com \
    --cc=john.linn@xilinx.com \
    --cc=johnlinn@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@petalogix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox