Re: [PATCH v3 5/5] driver: Google Memory Console

Ingo Molnar
2011-03-15T07:13:59Z

* Mike Waychison <mikew@google.com> wrote:

> +static struct dmi_system_id memconsole_dmi_table[] __initdata = {
> + {
> + .ident = "Google Board",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Google, Inc."),
> + },
> + },
> + {}
> +};
> +MODULE_DEVICE_TABLE(dmi, memconsole_dmi_table);
> +
> +static int __init memconsole_init(void)
> +{
> + int ret;
> +
> + if (!dmi_check_system(memconsole_dmi_table))
> + return -ENODEV;
> +
> + if (!found_memconsole())
> + return -ENODEV;

Ok, that's a much safer method of discovery.

Acked-by: Ingo Molnar <mingo@elte.hu>

Thanks,

Ingo