From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joern Engel <joern@logfs.org>, Dave Chinner <dchinner@redhat.com>,
werner <w.landgraf@ru.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.39-rc5-git2 boot crashs
Date: Sat, 30 Apr 2011 03:55:45 +0100 [thread overview]
Message-ID: <20110430025545.GI9487@ZenIV.linux.org.uk> (raw)
In-Reply-To: <BANLkTinv38NtVQHrayus6v89BocsK6+iQQ@mail.gmail.com>
On Fri, Apr 29, 2011 at 07:47:14PM -0700, Linus Torvalds wrote:
> On Fri, Apr 29, 2011 at 7:31 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > It looks like a NULL pointer dereference with offset 4, so at a guess,
> > super->s_freeing_list.next is NULL, and it's the "next->prev = entry"
> > instruction that faults when inserting into that list.
> >
> > How/why would s_freeing_list be NULL? I have no idea. But it looks
> > like a failed mount, so presumably it was never initialized.
>
> Hmm. super->s_freeing_list is initialized pretty late in
> logfs_read_sb(), and any error path _before_ that point will result in
> a "goto err1" in logfs_get_sb_device() which will do various iputs
> etc. All without that list initialized. That would seem to be the
> cause of this, possibly triggered by Al's changes to ->mount from
> read_super.
Then it ought to be reproducible with much ealier kernels. Say, 2.6.37 or
so... That part of ->mount() series went in during last Autumn...
next prev parent reply other threads:[~2011-04-30 2:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 22:10 2.6.39-rc5-git2 boot crashs werner
2011-04-30 2:31 ` Fwd: " Linus Torvalds
2011-04-30 2:47 ` Linus Torvalds
2011-04-30 2:55 ` Al Viro [this message]
2011-04-30 3:02 ` Al Viro
2011-04-30 3:09 ` Linus Torvalds
2011-04-30 3:27 ` Al Viro
2011-04-30 3:39 ` werner
2011-04-30 4:00 ` Linus Torvalds
2011-04-30 4:13 ` werner
2011-04-30 4:20 ` Linus Torvalds
[not found] ` <web-515904487@zbackend1.aha.ru>
[not found] ` <BANLkTimDHTB+NF8EzjvjBvu0e+MHt8tP1Q@mail.gmail.com>
2011-04-30 5:02 ` werner
2011-04-30 17:09 ` Linus Torvalds
[not found] ` <web-516060724@zbackend1.aha.ru>
2011-04-30 18:23 ` Linus Torvalds
2011-04-30 18:31 ` werner
2011-04-30 18:44 ` Justin P. Mattock
2011-04-30 5:26 ` werner
2011-04-30 4:00 ` werner
2011-04-30 4:29 ` werner
[not found] ` <web-515897851@zbackend1.aha.ru>
[not found] ` <BANLkTi==L3vDQ0jF9jP1hzhU-WmToBh=uA@mail.gmail.com>
[not found] ` <20110430114332.GC29280@htj.dyndns.org>
[not found] ` <4DBC09C7.9080205@fusionio.com>
[not found] ` <BANLkTimGJiugYaXW8c77dspjADrF+m4VHA@mail.gmail.com>
[not found] ` <web-516074613@zbackend1.aha.ru>
[not found] ` <BANLkTin8wf0T9nD9zmdh=4-rmj6WCy86cA@mail.gmail.com>
[not found] ` <web-516109980@zbackend1.aha.ru>
2011-05-01 2:53 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2011-05-01 1:52 werner
2011-05-01 2:52 ` Linus Torvalds
[not found] <web-516164730@zbackend1.aha.ru>
[not found] ` <BANLkTimda-mi2rjgnX0jqg7Pg-J6HSDb6w@mail.gmail.com>
2011-05-01 18:07 ` werner
2011-05-01 18:20 ` Linus Torvalds
2011-05-02 13:04 ` Steven Rostedt
2011-05-02 7:09 werner
2011-05-02 12:31 ` Steven Rostedt
2011-05-02 13:56 werner
2011-05-02 15:16 ` Steven Rostedt
[not found] <web-516390660@zbackend1.aha.ru>
2011-05-02 15:17 ` Linus Torvalds
2011-05-02 22:11 ` werner
2011-05-02 23:23 ` Linus Torvalds
2011-05-03 1:22 ` werner
2011-05-02 22:28 werner
2011-05-02 23:24 ` Linus Torvalds
[not found] ` <web-516990066@zbackend1.aha.ru>
2011-05-03 15:22 ` Linus Torvalds
2011-05-03 19:08 ` Ingo Molnar
2011-05-03 20:17 ` Linus Torvalds
2011-05-03 20:20 ` H. Peter Anvin
2011-05-03 20:50 ` Ingo Molnar
2011-05-03 21:45 ` Linus Torvalds
2011-05-03 22:01 ` H. Peter Anvin
2011-05-04 7:19 ` Borislav Petkov
2011-05-04 7:38 ` Ingo Molnar
2011-05-04 7:55 ` Borislav Petkov
2011-05-04 4:13 werner
[not found] <web-517412206@zbackend1.aha.ru>
2011-05-04 6:14 ` Ingo Molnar
2011-05-04 14:25 [block IO crash] " Tejun Heo
2011-05-04 14:46 ` Thomas Gleixner
2011-05-04 15:00 ` Christoph Lameter
2011-05-04 15:13 ` Linus Torvalds
2011-05-04 15:28 ` Christoph Lameter
2011-05-04 15:37 ` Pekka Enberg
2011-05-04 15:53 ` Linus Torvalds
2011-05-04 18:20 ` Linus Torvalds
[not found] ` <web-518008166@zbackend1.aha.ru>
[not found] ` <web-518059420@zbackend1.aha.ru>
[not found] ` <20110505060204.GA28015@elte.hu>
2011-05-05 6:46 ` werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110430025545.GI9487@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dchinner@redhat.com \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w.landgraf@ru.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox