From: Dave Jones <davej@redhat.com>
To: Greg KH <gregkh@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Allow setting of number of raw devices as a module parameter
Date: Sat, 30 Apr 2011 01:09:51 -0400 [thread overview]
Message-ID: <20110430050951.GA16557@redhat.com> (raw)
In-Reply-To: <20110430000704.GA3443@suse.de>
On Fri, Apr 29, 2011 at 05:07:04PM -0700, Greg KH wrote:
> On Fri, Apr 29, 2011 at 04:28:17PM -0700, Andrew Morton wrote:
> > On Fri, 29 Apr 2011 00:24:29 +0200
> > Jan Kara <jack@suse.cz> wrote:
> >
> > > Allow setting of maximal number of raw devices as a module parameter. This
> > > requires changing of static array into a vmalloced one (the array is going to
> > > be too large for kmalloc).
> > >
> >
> > Changelog failed to describe why the patch is needed. Lacking that
> > information, we have no reason to apply it.
>
> Good point, how about:
> People like running their machines with thousands of raw
> devices, yet distros don't want to take up that much memory for
> all users. Provide a way for everyone to be happy without
> forcing the module to be rebuilt by providing the ability to
> specify the number of raw devices as a module parameter option.
I remember when this was made a config option, thinking "8192 raw devices?
who would need that many?". I have to wonder just how someone manages
a system with an insane number of these devices.
Dave
next prev parent reply other threads:[~2011-04-30 5:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 22:24 Allow setting of number of raw devices as a module parameter Jan Kara
2011-04-29 23:19 ` Greg KH
2011-04-29 23:28 ` Andrew Morton
2011-04-30 0:07 ` Greg KH
2011-04-30 5:09 ` Dave Jones [this message]
2011-04-30 5:42 ` Greg KH
2011-04-30 10:29 ` Alan Cox
2011-04-30 15:34 ` Greg KH
2011-04-30 15:41 ` Alan Cox
2011-04-30 15:47 ` Greg KH
2011-05-02 19:22 ` Jan Kara
2011-05-03 9:42 ` Alan Cox
2011-04-30 12:15 ` Arnd Bergmann
2011-05-02 19:39 ` Jan Kara
2011-05-02 19:44 ` Arnd Bergmann
2011-05-02 21:11 ` Jan Kara
2011-05-03 10:55 ` Arnd Bergmann
2011-05-03 16:26 ` Jan Kara
2011-05-03 17:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110430050951.GA16557@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox