* [Oops 1/2]Something wrong with copy_from_user() function
@ 2011-04-30 6:13 Harry Wei
2011-04-30 12:41 ` Andy Lutomirski
2011-04-30 21:13 ` Jiri Kosina
0 siblings, 2 replies; 5+ messages in thread
From: Harry Wei @ 2011-04-30 6:13 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, greg, joe, randy.dunlap, trivial
Hi us,
When i was compiling 2.6.38.2 kernel. Something wrong happend to me.
It shows like following.
[...]
Warning: call to 'copy_from_user_overflow' declared with attribute warning:
copy_from_user buffer size is not provably correct.
[...]
See http://s1202.photobucket.com/albums/bb364/harrywei/Kernel/?action=view¤t=report_bug.png for details.
I tried to fix this warning, but i don't know how to deal with
it. Can anyone help me.
Thanks.
Harry Wei.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Oops 1/2]Something wrong with copy_from_user() function
2011-04-30 6:13 [Oops 1/2]Something wrong with copy_from_user() function Harry Wei
@ 2011-04-30 12:41 ` Andy Lutomirski
2011-04-30 21:13 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Andy Lutomirski @ 2011-04-30 12:41 UTC (permalink / raw)
To: linux-kernel, akpm, greg, joe, randy.dunlap, trivial
On 04/30/2011 02:13 AM, Harry Wei wrote:
> Hi us,
> When i was compiling 2.6.38.2 kernel. Something wrong happend to me.
> It shows like following.
>
> [...]
> Warning: call to 'copy_from_user_overflow' declared with attribute warning:
> copy_from_user buffer size is not provably correct.
> [...]
>
> See http://s1202.photobucket.com/albums/bb364/harrywei/Kernel/?action=view¤t=report_bug.png for details.
> I tried to fix this warning, but i don't know how to deal with
> it. Can anyone help me.
That's a bug (maybe) in drivers/staging/vt6656/wpactl.c, which is a
staging driver and therefore liable to be imperfect. You could ignore
it or fix it and submit a patch.
(The bug isn't in copy_from_user -- it's an intentional warning in there
to indicate that something might be wrong with the caller.)
--Andy
>
> Thanks.
> Harry Wei.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Oops 1/2]Something wrong with copy_from_user() function
2011-04-30 6:13 [Oops 1/2]Something wrong with copy_from_user() function Harry Wei
2011-04-30 12:41 ` Andy Lutomirski
@ 2011-04-30 21:13 ` Jiri Kosina
2011-05-01 1:21 ` Harry Wei
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2011-04-30 21:13 UTC (permalink / raw)
To: Harry Wei; +Cc: linux-kernel, akpm, greg, joe, randy.dunlap
On Sat, 30 Apr 2011, Harry Wei wrote:
> Hi us,
> When i was compiling 2.6.38.2 kernel. Something wrong happend to me.
> It shows like following.
>
> [...]
> Warning: call to 'copy_from_user_overflow' declared with attribute warning:
> copy_from_user buffer size is not provably correct.
> [...]
>
> See http://s1202.photobucket.com/albums/bb364/harrywei/Kernel/?action=view¤t=report_bug.png for details.
> I tried to fix this warning, but i don't know how to deal with
> it. Can anyone help me.
wpa_set_keys() function (from staging drivers) in your kernel uses
copy_from_user() without proper bounds checking, and thus can overflow and
corrupt memory.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Oops 1/2]Something wrong with copy_from_user() function
2011-04-30 21:13 ` Jiri Kosina
@ 2011-05-01 1:21 ` Harry Wei
2011-05-01 2:39 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Harry Wei @ 2011-05-01 1:21 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel, akpm, greg, randy.dunlap, joe
On Sat, Apr 30, 2011 at 11:13:10PM +0200, Jiri Kosina wrote:
> On Sat, 30 Apr 2011, Harry Wei wrote:
>
>
> wpa_set_keys() function (from staging drivers) in your kernel uses
> copy_from_user() without proper bounds checking, and thus can overflow and
> corrupt memory.
Hmmm, i see.
Thanks.
Harry Wei.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Oops 1/2]Something wrong with copy_from_user() function
2011-05-01 1:21 ` Harry Wei
@ 2011-05-01 2:39 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2011-05-01 2:39 UTC (permalink / raw)
To: Jiri Kosina, linux-kernel, akpm, randy.dunlap, joe
On Sun, May 01, 2011 at 09:21:30AM +0800, Harry Wei wrote:
> On Sat, Apr 30, 2011 at 11:13:10PM +0200, Jiri Kosina wrote:
> > On Sat, 30 Apr 2011, Harry Wei wrote:
> >
> >
> > wpa_set_keys() function (from staging drivers) in your kernel uses
> > copy_from_user() without proper bounds checking, and thus can overflow and
> > corrupt memory.
> Hmmm, i see.
Patches gladly welcome to fix this :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-01 15:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-30 6:13 [Oops 1/2]Something wrong with copy_from_user() function Harry Wei
2011-04-30 12:41 ` Andy Lutomirski
2011-04-30 21:13 ` Jiri Kosina
2011-05-01 1:21 ` Harry Wei
2011-05-01 2:39 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
