From: Samuel Ortiz <sameo@linux.intel.com>
To: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, lrg@ti.com,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCHv5 1/4] MFD: TPS65910: Add new mfd device for TPS65910
Date: Mon, 2 May 2011 17:27:02 +0200 [thread overview]
Message-ID: <20110502152701.GG8222@sortiz-mobl> (raw)
In-Reply-To: <C3F379CD-4C84-4E7F-BD6F-078E04F15F65@slimlogic.co.uk>
Hi Jorge,
On Wed, Apr 27, 2011 at 10:51:00AM -0500, Jorge Eduardo Candelaria wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
>
> The TPS65910 chip is a power management IC for multimedia and handheld
> devices. It contains the following components:
>
> - Regulators
> - GPIO controller
> - RTC
>
> The tps65910 core driver is registered as a platform driver and provides
> communication through I2C with the host device for the different
> components.
I'm going to be picky here:
> +static DEFINE_MUTEX(io_mutex);
Having this mutex in the tps65910 structure would be cleaner. I know the
likeliness of having 2 of those devices in one system is very low, but still,
it would be nicer.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-05-02 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 15:51 [PATCHv5 1/4] MFD: TPS65910: Add new mfd device for TPS65910 Jorge Eduardo Candelaria
2011-05-02 15:27 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502152701.GG8222@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox