public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: wanlong.gao@gmail.com, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] KernelDoc:Add the device driver-model structures to kerneldoc
Date: Mon, 2 May 2011 08:39:02 -0700	[thread overview]
Message-ID: <20110502153902.GA8098@suse.de> (raw)
In-Reply-To: <20110502082609.77b23473.rdunlap@xenotime.net>

On Mon, May 02, 2011 at 08:26:09AM -0700, Randy Dunlap wrote:
> On Mon,  2 May 2011 23:04:40 +0800 wanlong.gao@gmail.com wrote:
> 
> > From: Wanlong Gao <wanlong.gao@gmail.com>
> > 
> > Add the comment the structure bus_type, device_driver, device,
> > class for generating the driver-model kerneldoc.
> 
> Warning: trailing whitespace in lines 66,478,498,499 of include/linux/device.h
> 
> Other than that:
> 
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
> 
> Thanks.
> 
> Greg, do you want to merge this or should I?

Please don't, I have some issues with it that I will respond to in a
minute.

thanks,

greg k-h

  reply	other threads:[~2011-05-02 15:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-02 15:04 [PATCH 0/2] KernelDoc:Move the driver model structure to the kerneldoc wanlong.gao
2011-05-02 15:04 ` [PATCH 1/2] KernelDoc:Add the device driver-model structures to kerneldoc wanlong.gao
2011-05-02 15:26   ` Randy Dunlap
2011-05-02 15:39     ` Greg KH [this message]
2011-05-02 15:41     ` wanlong.gao
2011-05-02 15:43   ` Greg KH
2011-05-02 15:51     ` Wanlong Gao
2011-05-02 15:04 ` [PATCH 2/2] Documentation:remove the driver-model structures from the docs wanlong.gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110502153902.GA8098@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=wanlong.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox