From: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, hirofuchi@users.sourceforge.net,
arjan.mels@gmx.net, rjw@sisk.pl,
Stanislav SCHATTKE <schattke@linuxbox.cz>
Subject: Re: [regression?] d199c96d41d80a567493e12b8e96ea056a1350c1 breaks usbip
Date: Mon, 2 May 2011 18:59:50 +0200 [thread overview]
Message-ID: <20110502165950.GA2550@nik-comp.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1105021008491.2106-100000@iolanthe.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
> Here's a patch which should fix the problem. Nikola, can you test it?
>
> Alan Stern
>
>
>
> Index: usb-2.6/drivers/staging/usbip/vhci_hcd.c
> ===================================================================
> --- usb-2.6.orig/drivers/staging/usbip/vhci_hcd.c
> +++ usb-2.6/drivers/staging/usbip/vhci_hcd.c
> @@ -1139,7 +1139,7 @@ static int vhci_hcd_probe(struct platfor
> usbip_uerr("create hcd failed\n");
> return -ENOMEM;
> }
> -
> + hcd->has_tt = 1;
>
> /* this is private data for vhci_hcd */
> the_controller = hcd_to_vhci(hcd);
>
Yes, it does!
thanks Alan! I'll now try bisect as Greg suggested to see where usbip got broken in latest git...
Greg, will You please push this to stable once it reaches upstream?
cheers!
n.
--
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava
tel.: +420 596 603 142
fax: +420 596 621 273
mobil: +420 777 093 799
www.linuxbox.cz
mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-05-02 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 18:10 [regression?] d199c96d41d80a567493e12b8e96ea056a1350c1 breaks usbip Nikola Ciprich
2011-05-01 19:27 ` Greg KH
2011-05-02 14:09 ` Alan Stern
2011-05-02 16:59 ` Nikola Ciprich [this message]
2011-05-02 20:41 ` Nikola Ciprich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502165950.GA2550@nik-comp.lan \
--to=nikola.ciprich@linuxbox.cz \
--cc=arjan.mels@gmx.net \
--cc=greg@kroah.com \
--cc=hirofuchi@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=schattke@linuxbox.cz \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox