Re: [PATCH tip/core/rcu 10/86] rcu: eliminate unused boosting statistics

Paul E. McKenney
2011-05-02T08:26:07Z

On Sun, May 01, 2011 at 08:53:18AM -0700, Josh Triplett wrote:
> On Sun, May 01, 2011 at 06:20:50AM -0700, Paul E. McKenney wrote:
> > From: Paul E. McKenney <paul.mckenney@linaro.org>
> >
> > The n_rcu_torture_boost_allocerror and n_rcu_torture_boost_afferror
> > statistics are not actually incremented anymore, so eliminate them.
> >
> > Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > ---
> > kernel/rcutorture.c | 4 +---
> > 1 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> > index 4d256db..62ec8ee6 100644
> > --- a/kernel/rcutorture.c
> > +++ b/kernel/rcutorture.c
> > @@ -1067,7 +1067,7 @@ rcu_torture_printk(char *page)
> > cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG);
> > cnt += sprintf(&page[cnt],
> > "rtc: %p ver: %ld tfle: %d rta: %d rtaf: %d rtf: %d "
> > - "rtmbe: %d rtbke: %ld rtbre: %ld rtbae: %ld rtbafe: %ld "
> > + "rtmbe: %d rtbke: %ld rtbre: %ld "
> > "rtbf: %ld rtb: %ld nt: %ld",
> > rcu_torture_current,
> > rcu_torture_current_version,
> > @@ -1078,8 +1078,6 @@ rcu_torture_printk(char *page)
> > atomic_read(&n_rcu_torture_mberror),
> > n_rcu_torture_boost_ktrerror,
> > n_rcu_torture_boost_rterror,
> > - n_rcu_torture_boost_allocerror,
> > - n_rcu_torture_boost_afferror,
> > n_rcu_torture_boost_failure,
> > n_rcu_torture_boosts,
> > n_rcu_torture_timers);
>
> Shouldn't you eliminate the variables entirely, if they no longer track
> anything?

I most certainly should!!! Good catch!!!

Thanx, Paul