Re: [RFC patch 29/32] trace event asoc remove semicolons

Mark Brown
2011-05-03T14:14:40Z

On Tue, May 03, 2011 at 10:06:47AM -0400, Mathieu Desnoyers wrote:
> * Mark Brown (broonie@opensource.wolfsonmicro.com) wrote:

> > This is an unrelated change and should be split out. Frankly I'm not
> > that this is an improvement anyway, the struct declarations aren't going
> > to do any harm...

> Yes, this change is related, because these declarations will cause harm.
> The structure declaration cannot be put within an array declaration,
> because then they won't be simply "ignored": they will try to declare
> structures within an array, which is not valid. This is why I did this
> change in the same patch.

This might make a bit more sense if we'd seen the earlier or possibly
later patches... According to the patch description all you're doing
here is removing the semicolons.