Re: [RFC][PATCH] PM: Print a warning if firmware is requested when tasks are frozen

[Greg KH <gregkh@suse.de>]

On Mon, May 02, 2011 at 04:21:09PM -0700, Linus Torvalds wrote:
> On Mon, May 2, 2011 at 4:12 PM, Greg KH <gregkh@suse.de> wrote:
> >
> > But you can safely call this function with nowait set, and this warning
> > should not be triggered, right?
> 
> Why would you want that?
> 
> It's _always_ wrong to ask for firmware during resume. "nowait" or not
> is totally irrelevant. A driver that depends on the firmware being
> built in to the kernel is a buggy driver, why would you want to
> silently allow that kind of crap? It's just a timebomb waiting for
> somebody to compile the kernel differently.

A driver that does not rely on the firmware being built in would be
correct in calling request_firmware_nowait() on resume, then when
userspace is properly woken up, the firmware would be sent to the
device, then the driver would be notified, load it, and handle things
as part of its resume sequence from that notification.

Isn't that ideally what we want to have happen?

Or am I missing something else?

thanks,

greg k-h