Re: [PATCH 4/4] x86, mce: Have MCE persistent event off by default for now

[Borislav Petkov <bp@amd64.org>]

On Tue, May 03, 2011 at 02:45:05AM -0400, Ingo Molnar wrote:
> 
> * Borislav Petkov <bp@amd64.org> wrote:
> 
> > From: Borislav Petkov <borislav.petkov@amd.com>
> > 
> > This is new functionality and it affects all of x86 so we want to be
> > very conservative about it and have it off by default for now, in case
> > something goes awry. You can always enable it by supplying "ras" on the
> > kernel command line.
> > 
> > Also, depending on whether it is enabled or not, we emit the tracepoint
> > from a different place in the code to pick up additional decoded info.
> > 
> > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> > ---
> >  Documentation/kernel-parameters.txt |    2 ++
> >  arch/x86/include/asm/mce.h          |    1 +
> >  arch/x86/kernel/cpu/mcheck/mce.c    |   32 ++++++++++++++++++++++++++++++--
> >  drivers/edac/mce_amd.c              |    5 +++++
> >  4 files changed, 38 insertions(+), 2 deletions(-)
> 
> the boot flag is fine - but please keep it enabled by default if MCE support is 
> enabled in the .config, we do not chicken out when it comes to testing new 
> code! :-)

Ok, the problem I see with it is that people without a RAS daemon
running will have the mechanism collecting MCEs in the background, using
up resources (4 pages per CPU is the buffer) and not doing anything (in
the best case that is, when we're not broken otherwise).

Do we want to have that on all x86 turned on by default? Or maybe invert
the flag semantics so that people can disable it on boot?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632