From: Greg KH <gregkh@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Valdis.Kletnieks@vt.edu, LKML <linux-kernel@vger.kernel.org>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC][PATCH] PM: Print a warning if firmware is requested when tasks are frozen
Date: Tue, 3 May 2011 07:06:08 -0700 [thread overview]
Message-ID: <20110503140608.GB7944@suse.de> (raw)
In-Reply-To: <201105031302.08910.rjw@sisk.pl>
On Tue, May 03, 2011 at 01:02:08PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: PM: Print a warning if firmware is requested when tasks are frozen
>
> Some drivers erroneously use request_firmware() from their ->resume()
> (or ->thaw(), or ->restore()) callbacks, which is not going to work
> unless the firmware has been built in. This causes system resume to
> stall until the firmware-loading timeout expires, which makes users
> think that the resume has failed and reboot their machines
> unnecessarily. For this reason, make _request_firmware() print a
> warning and return immediately with error code if it has been called
> when tasks are frozen and it's impossible to start any new usermode
> helpers.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
I'm guessing you will take this through your tree? If so, that's great:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2011-05-03 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 22:44 [RFC][PATCH] PM: Print a warning if firmware is requested when tasks are frozen Rafael J. Wysocki
2011-05-02 23:12 ` Greg KH
2011-05-02 23:21 ` Linus Torvalds
2011-05-02 23:28 ` Greg KH
2011-05-03 0:59 ` Linus Torvalds
2011-05-03 14:05 ` Greg KH
2011-05-02 23:30 ` Valdis.Kletnieks
2011-05-03 11:02 ` Rafael J. Wysocki
2011-05-03 14:06 ` Greg KH [this message]
2011-05-03 17:12 ` Rafael J. Wysocki
2011-05-03 15:47 ` Valdis.Kletnieks
2011-05-03 15:56 ` Joe Perches
2011-05-03 17:14 ` Rafael J. Wysocki
[not found] ` <201105031914.18160.rjw@sisk.pl>
2011-05-03 18:03 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503140608.GB7944@suse.de \
--to=gregkh@suse.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox