From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
lrg@slimlogic.co.uk
Subject: Re: [RFC patch 29/32] trace event asoc remove semicolons
Date: Tue, 3 May 2011 15:29:54 +0100 [thread overview]
Message-ID: <20110503142954.GQ1762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110502213216.050459585@efficios.com>
On Mon, May 02, 2011 at 05:11:52PM -0400, Mathieu Desnoyers wrote:
> Part of the gradual TRACE_EVENT() semicolon removal. Enables creation of array
> of events, thus saving space for trace event probes.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
and adding Liam.
> ---
> include/trace/events/asoc.h | 39 ++++++++++++++++++++++-----------------
> 1 file changed, 22 insertions(+), 17 deletions(-)
>
> Index: linux-2.6-lttng/include/trace/events/asoc.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/trace/events/asoc.h
> +++ linux-2.6-lttng/include/trace/events/asoc.h
> @@ -7,11 +7,16 @@
> #include <linux/ktime.h>
> #include <linux/tracepoint.h>
>
> +#ifndef _TRACE_ASOC_DEF_
> +#define _TRACE_ASOC_DEF_
> +
> struct snd_soc_jack;
> struct snd_soc_codec;
> struct snd_soc_card;
> struct snd_soc_dapm_widget;
>
> +#endif /* _TRACE_ASOC_DEF_ */
> +
> /*
> * Log register events
> */
> @@ -39,7 +44,7 @@ DECLARE_EVENT_CLASS(snd_soc_reg,
> TP_printk("codec=%s.%d reg=%x val=%x", __get_str(name),
> (int)__entry->id, (unsigned int)__entry->reg,
> (unsigned int)__entry->val)
> -);
> +)
>
> DEFINE_EVENT(snd_soc_reg, snd_soc_reg_write,
>
> @@ -48,7 +53,7 @@ DEFINE_EVENT(snd_soc_reg, snd_soc_reg_wr
>
> TP_ARGS(codec, reg, val)
>
> -);
> +)
>
> DEFINE_EVENT(snd_soc_reg, snd_soc_reg_read,
>
> @@ -57,7 +62,7 @@ DEFINE_EVENT(snd_soc_reg, snd_soc_reg_re
>
> TP_ARGS(codec, reg, val)
>
> -);
> +)
>
> DECLARE_EVENT_CLASS(snd_soc_card,
>
> @@ -76,7 +81,7 @@ DECLARE_EVENT_CLASS(snd_soc_card,
> ),
>
> TP_printk("card=%s val=%d", __get_str(name), (int)__entry->val)
> -);
> +)
>
> DEFINE_EVENT(snd_soc_card, snd_soc_bias_level_start,
>
> @@ -84,7 +89,7 @@ DEFINE_EVENT(snd_soc_card, snd_soc_bias_
>
> TP_ARGS(card, val)
>
> -);
> +)
>
> DEFINE_EVENT(snd_soc_card, snd_soc_bias_level_done,
>
> @@ -92,7 +97,7 @@ DEFINE_EVENT(snd_soc_card, snd_soc_bias_
>
> TP_ARGS(card, val)
>
> -);
> +)
>
> DECLARE_EVENT_CLASS(snd_soc_dapm_basic,
>
> @@ -109,7 +114,7 @@ DECLARE_EVENT_CLASS(snd_soc_dapm_basic,
> ),
>
> TP_printk("card=%s", __get_str(name))
> -);
> +)
>
> DEFINE_EVENT(snd_soc_dapm_basic, snd_soc_dapm_start,
>
> @@ -117,7 +122,7 @@ DEFINE_EVENT(snd_soc_dapm_basic, snd_soc
>
> TP_ARGS(card)
>
> -);
> +)
>
> DEFINE_EVENT(snd_soc_dapm_basic, snd_soc_dapm_done,
>
> @@ -125,7 +130,7 @@ DEFINE_EVENT(snd_soc_dapm_basic, snd_soc
>
> TP_ARGS(card)
>
> -);
> +)
>
> DECLARE_EVENT_CLASS(snd_soc_dapm_widget,
>
> @@ -145,7 +150,7 @@ DECLARE_EVENT_CLASS(snd_soc_dapm_widget,
>
> TP_printk("widget=%s val=%d", __get_str(name),
> (int)__entry->val)
> -);
> +)
>
> DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_power,
>
> @@ -153,7 +158,7 @@ DEFINE_EVENT(snd_soc_dapm_widget, snd_so
>
> TP_ARGS(w, val)
>
> -);
> +)
>
> DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_event_start,
>
> @@ -161,7 +166,7 @@ DEFINE_EVENT(snd_soc_dapm_widget, snd_so
>
> TP_ARGS(w, val)
>
> -);
> +)
>
> DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_event_done,
>
> @@ -169,7 +174,7 @@ DEFINE_EVENT(snd_soc_dapm_widget, snd_so
>
> TP_ARGS(w, val)
>
> -);
> +)
>
> TRACE_EVENT(snd_soc_jack_irq,
>
> @@ -186,7 +191,7 @@ TRACE_EVENT(snd_soc_jack_irq,
> ),
>
> TP_printk("%s", __get_str(name))
> -);
> +)
>
> TRACE_EVENT(snd_soc_jack_report,
>
> @@ -208,7 +213,7 @@ TRACE_EVENT(snd_soc_jack_report,
>
> TP_printk("jack=%s %x/%x", __get_str(name), (int)__entry->val,
> (int)__entry->mask)
> -);
> +)
>
> TRACE_EVENT(snd_soc_jack_notify,
>
> @@ -227,7 +232,7 @@ TRACE_EVENT(snd_soc_jack_notify,
> ),
>
> TP_printk("jack=%s %x", __get_str(name), (int)__entry->val)
> -);
> +)
>
> TRACE_EVENT(snd_soc_cache_sync,
>
> @@ -252,7 +257,7 @@ TRACE_EVENT(snd_soc_cache_sync,
>
> TP_printk("codec=%s.%d type=%s status=%s", __get_str(name),
> (int)__entry->id, __get_str(type), __get_str(status))
> -);
> +)
>
> #endif /* _TRACE_ASOC_H */
>
>
next prev parent reply other threads:[~2011-05-03 14:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 21:11 [RFC patch 00/32] TRACE_EVENT: cleanup for code-size reduction Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 02/32] trace event sample remove semicolons, specify need for ifdef around declarations Mathieu Desnoyers
2011-05-03 14:31 ` Steven Rostedt
2011-05-02 21:11 ` [RFC patch 03/32] trace event block remove semicolumns Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 04/32] trace event ext4 remove semicolons Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 05/32] trace event irq " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 06/32] trace event jbd2 " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 07/32] trace event kmem " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 08/32] trace event kvm " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 09/32] trace event lock " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 10/32] trace event mce " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 11/32] trace event module " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 12/32] trace event napi " Mathieu Desnoyers
2011-05-03 12:26 ` Neil Horman
2011-05-02 21:11 ` [RFC patch 13/32] trace event net " Mathieu Desnoyers
2011-05-03 12:27 ` Neil Horman
2011-05-02 21:11 ` [RFC patch 14/32] trace event power " Mathieu Desnoyers
2011-05-03 12:59 ` Pihet-XID, Jean
2011-05-02 21:11 ` [RFC patch 15/32] trace event sched remove trailing semicolon Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 16/32] trace event scsi remove semicolons Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 17/32] trace event signal " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 18/32] trace event skb " Mathieu Desnoyers
2011-05-03 12:27 ` Neil Horman
2011-05-02 21:11 ` [RFC patch 19/32] trace event syscalls " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 20/32] trace event timer " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 21/32] trace event vmscan " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 22/32] trace event workqueue " Mathieu Desnoyers
2011-05-03 8:25 ` Tejun Heo
2011-05-02 21:11 ` [RFC patch 23/32] trace event writeback " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 24/32] trace event wireless " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 25/32] trace event video gpu " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 26/32] trace event gfs2 " Mathieu Desnoyers
2011-05-03 10:14 ` Steven Whitehouse
2011-05-03 21:13 ` Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 27/32] trace event xfs " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 28/32] trace event powerpc " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 29/32] trace event asoc " Mathieu Desnoyers
2011-05-03 13:21 ` Mark Brown
2011-05-03 14:06 ` Mathieu Desnoyers
2011-05-03 14:14 ` Mark Brown
2011-05-03 14:24 ` Mark Brown
2011-05-03 14:34 ` Steven Rostedt
2011-05-03 21:29 ` Mathieu Desnoyers
2011-05-03 20:57 ` Mathieu Desnoyers
2011-05-03 21:30 ` Mathieu Desnoyers
2011-05-03 14:30 ` Steven Rostedt
2011-05-03 14:29 ` Mark Brown [this message]
2011-05-02 21:11 ` [RFC patch 30/32] trace event compaction " Mathieu Desnoyers
2011-05-02 21:11 ` [RFC patch 31/32] trace event regulator " Mathieu Desnoyers
2011-05-03 14:30 ` Mark Brown
2011-05-02 21:11 ` [RFC patch 32/32] trace event btrfs " Mathieu Desnoyers
[not found] ` <20110502213211.250108074@efficios.com>
2011-05-03 14:07 ` [RFC patch 01/32] TRACE_EVENT: gradual semicolon removal Mathieu Desnoyers
2011-05-03 14:37 ` Steven Rostedt
2011-05-03 14:53 ` Mark Brown
[not found] ` <1304422337.25414.2382.camel@gandalf.stny.rr.com>
2011-05-03 21:26 ` Mathieu Desnoyers
2011-05-03 22:01 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503142954.GQ1762@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox