From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
jimmy.chen@moxa.com, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH 2/2] watchdog: add support for MOXA V2100 watchdog driver
Date: Tue, 3 May 2011 14:51:56 +0200 [thread overview]
Message-ID: <201105031451.56911.arnd@arndb.de> (raw)
In-Reply-To: <20110503121510.5bba70c5@lxorguk.ukuu.org.uk>
On Tuesday 03 May 2011, Alan Cox wrote:
> > Hmm, code in a header? Can't this go into the main source? Hmm, at least
> > it87_wdt.c has something very similar. Maybe it can even be shared? What
> > about locking BTW?
>
> The spinlock handles it if you look at the caller points, because you
> have to own the super I/O and select it each time.
I suppose the functions should at least be 'static inline' so they avoid
polluting the global namespace.
> Ultimately it wants to be using request_muxed_* but that isn't in any of
> the mainstream code yet so can be done in the future when the mux patches
> go in.
Another thing that might be nice here is to have one module that probes
the superio-port and then registers a platform device that other drivers
can can bind to. Right now, you have to load the module manually and
then check if it's there, something we no longer do for most devices.
Arnd
next prev parent reply other threads:[~2011-05-03 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 5:36 [PATCH 1/2] watchdog: add support for MOXA V2100 watchdog driver Jimmy Chen (陳永達)
2011-05-03 5:38 ` [PATCH 2/2] " Jimmy Chen (陳永達)
2011-05-03 9:37 ` Alan Cox
2011-05-03 10:25 ` Jimmy Chen (陳永達)
2011-05-03 10:29 ` Alan Cox
2011-05-03 10:57 ` Wolfram Sang
2011-05-03 11:15 ` Alan Cox
2011-05-03 12:51 ` Arnd Bergmann [this message]
2011-05-03 13:35 ` Alan Cox
2011-05-04 9:02 ` Jimmy Chen (陳永達)
2011-05-06 5:52 ` Jimmy Chen (陳永達)
2011-05-06 6:59 ` Arnd Bergmann
2011-05-19 16:01 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105031451.56911.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jimmy.chen@moxa.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=w.sang@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox