Re: [RFC patch 18/32] trace event skb remove semicolons

Neil Horman
2011-05-03T12:27:42Z

On Mon, May 02, 2011 at 05:11:41PM -0400, Mathieu Desnoyers wrote:
> Part of the gradual TRACE_EVENT() semicolon removal. Enables creation of array
> of events, thus saving space for trace event probes.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
> CC: Neil Horman <nhorman@tuxdriver.com>
> CC: David S. Miller <davem@davemloft.net>
> ---
Acked-by: Neil Horman <nhorman@tuxdriver.com>

> include/trace/events/skb.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6-lttng/include/trace/events/skb.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/trace/events/skb.h
> +++ linux-2.6-lttng/include/trace/events/skb.h
> @@ -31,7 +31,7 @@ TRACE_EVENT(kfree_skb,
>
> TP_printk("skbaddr=%p protocol=%u location=%p",
> __entry->skbaddr, __entry->protocol, __entry->location)
> -);
> +)
>
> TRACE_EVENT(consume_skb,
>
> @@ -48,7 +48,7 @@ TRACE_EVENT(consume_skb,
> ),
>
> TP_printk("skbaddr=%p", __entry->skbaddr)
> -);
> +)
>
> TRACE_EVENT(skb_copy_datagram_iovec,
>
> @@ -67,7 +67,7 @@ TRACE_EVENT(skb_copy_datagram_iovec,
> ),
>
> TP_printk("skbaddr=%p len=%d", __entry->skbaddr, __entry->len)
> -);
> +)
>
> #endif /* _TRACE_SKB_H */
>
>
>